From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests <fstests@vger.kernel.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH 2/2] fstests: use _scratch_mount_nocheck where appropriate in tests
Date: Tue, 13 Feb 2018 18:09:02 +0800 [thread overview]
Message-ID: <20180213100902.GK18267@eguan.usersys.redhat.com> (raw)
In-Reply-To: <CAOQ4uxjqiutLKnYj4FhU9pT516bv-OVqfiwdjVcV5OMq_FNN4w@mail.gmail.com>
On Tue, Feb 13, 2018 at 11:58:48AM +0200, Amir Goldstein wrote:
> On Tue, Feb 13, 2018 at 11:12 AM, Eryu Guan <eguan@redhat.com> wrote:
> > Also remove redundant status checks of _scratch_mount.
>
> Is there any correlation between tests that need to use _scratch_mount_nocheck
> tests which _require_scratch_nocheck that could make some of these annotations
> automatic?
No, they have totally different meanings. _require_scratch_nocheck means
don't do filesystem check after test, and _scratch_mount_nocheck means
don't check mount status.
Perhaps it's just badly named, I can follow Andreas's suggestion to name
it as _try_scratch_mount or similar names.
Thanks,
Eryu
next prev parent reply other threads:[~2018-02-13 10:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:12 [RFC PATCH 0/2] _fail test by default if _scratch_mount fails Eryu Guan
2018-02-13 9:12 ` [PATCH 1/2] fstests: introduce _scratch_mount_nocheck Eryu Guan
2018-02-13 14:11 ` Andreas Gruenbacher
2018-02-14 3:30 ` Eryu Guan
2018-02-13 9:12 ` [PATCH 2/2] fstests: use _scratch_mount_nocheck where appropriate in tests Eryu Guan
2018-02-13 9:58 ` Amir Goldstein
2018-02-13 10:09 ` Eryu Guan [this message]
2018-02-13 10:37 ` Andreas Gruenbacher
2018-02-13 23:31 ` Darrick J. Wong
2018-02-14 3:21 ` Eryu Guan
2018-02-13 14:15 ` [RFC PATCH 0/2] _fail test by default if _scratch_mount fails Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213100902.GK18267@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=agruenba@redhat.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox