Re: [PATCH v3] generic: add stress test for fanotify and inotify

Xiong Zhou
2018-02-12T05:38:25Z

On Mon, Feb 12, 2018 at 04:08:40PM +1100, Dave Chinner wrote:
> On Mon, Feb 12, 2018 at 12:33:57PM +0800, Xiong Zhou wrote:
> > On Mon, Feb 12, 2018 at 05:50:21AM +0200, Amir Goldstein wrote:
> > > Patchset is for a reason - the reason is that all patches should be
> > > reviewed and merged together. But that's got nothing to do with the
> > > reason you should list the fix commit in test description.
> > > The reason for that is that testers needs to know if test is expected to
> > > fail or pass on the kernel they are using.
> >
> > AFAIK, known issue tracking is not handled by fstests.
>
> And by that reasoning, commit IDs for bug fixes should not be in
> fstests at all.
>
> However, it is useful to many people to have a reference to the fix
> associated with the test (or at least it's initial commit). That can
> either be a commit ID or a url that points to the patch on the
> mailing list that will be committed to fix it.
>
> > > Listing the cleanup patches does not serve this purpose.
> > > In fact, it may confuse people testing stable kernels, because stable
> > > kernel could have fix patches applied but not all cleanup patches.
> >
> > Interesting, I'm listing all of them and I'm saying "fixed by this series"
> > not "fixed by this commit".
>
> That's way too much irrelevant information, especially as "issue
> tracking is not handled by fstests".

Fair enough.

>
> Please listen to Amir and follow the convention that everyone has
> agreed on for referencing the fix a regression test relates to.

Okay.

Thanks,
Xiong
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com