Re: [PATCH v3] generic: add stress test for fanotify and inotify

Xiong Zhou
2018-02-12T00:41:30Z

On Sun, Feb 11, 2018 at 10:03:17PM +0200, Amir Goldstein wrote:
> On Sun, Feb 11, 2018 at 8:59 AM, Xiong Zhou <xzhou@redhat.com> wrote:
> > Stress test for fanotify and inotify. Exercise fanotify and
> > inotify user interfaces in loop while other stress tests going
> > on in the watched test directory.
> >
> > Watching slab object inotify_inode_mark size, report fail
> > it increases too fast. This may lead to a crash if OOM killer
> > invoked. Fixed by this series:
> >
> > ab97f87 fsnotify: convert fsnotify_mark.refcnt from atomic_t to ref..
> > 6685df3 fanotify: clean up CONFIG_FANOTIFY_ACCESS_PERMISSIONS ifdefs
> > 3427ce7 fsnotify: clean up fsnotify()
> > f37650f fanotify: fix fsnotify_prepare_user_wait() failure
> > 9a31d7a fsnotify: fix pinning group in fsnotify_prepare_user_wait()
>
> That's a bit much. This commit below is the actual fix.
> The rest are cleanups and other bug fixes.

Cleanups are preparing for the fix. I believe it's better to list
the whole series. They are a patchset for some reason.

> It could also help testers to know the upstream kernel version
> where the fix landed:

There is no such info in other cases listing kernel commits. If
people want to know, they will find it out.

Thanks,
Xiong

>
> 0d6ec07 fsnotify: pin both inode and vfsmount mark
>
> Otherwise, looks good.
>
> Amir.