From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/25[02]: increase filesystem size
Date: Wed, 21 Feb 2018 18:28:00 -0800 [thread overview]
Message-ID: <20180222022800.GC14582@magnolia> (raw)
In-Reply-To: <20180222003203.20231-1-david@fromorbit.com>
On Thu, Feb 22, 2018 at 11:32:03AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> On reflink+rmapbt XFs filesystems there isn't enough free space to
> run this test on the 64MB filesystem image created. It notruns with
> a curious error message - needs at least 0GB free:
>
> generic/250 [10:01:57] [10:01:58] [not run]
> generic/250 -- This test requires at least 0GB free on /mnt/scratch to run
TBH I think someone ought to fix that to spit out MB if < 1024M, but
that's a different patch.
Worksforme,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> Fix this by increasing the size of the base filesystem image.
>
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
> ---
> tests/generic/250 | 6 +++---
> tests/generic/252 | 5 +++--
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tests/generic/250 b/tests/generic/250
> index a8fd97e31ff0..6b0f7e3126af 100755
> --- a/tests/generic/250
> +++ b/tests/generic/250
> @@ -54,10 +54,10 @@ _require_no_rtinherit
>
> rm -f $seqres.full
>
> -
> +fssize=$((100 * 1048576))
> echo "Format and mount"
> -$XFS_IO_PROG -d -c "pwrite -S 0x69 -b 1048576 0 $((64 * 1048576))" $SCRATCH_DEV >> $seqres.full
> -_scratch_mkfs_sized $((64 * 1048576)) > $seqres.full 2>&1
> +$XFS_IO_PROG -d -c "pwrite -S 0x69 -b 1048576 0 $fssize" $SCRATCH_DEV >> $seqres.full
> +_scratch_mkfs_sized $fssize > $seqres.full 2>&1
> _dmerror_init
> _dmerror_mount >> $seqres.full 2>&1
> _dmerror_unmount
> diff --git a/tests/generic/252 b/tests/generic/252
> index b506d599f638..e102945d83b7 100755
> --- a/tests/generic/252
> +++ b/tests/generic/252
> @@ -56,9 +56,10 @@ AIO_TEST="src/aio-dio-regress/aiocp"
> rm -f $seqres.full
>
>
> +fssize=$((100 * 1048576))
> echo "Format and mount"
> -$XFS_IO_PROG -d -c "pwrite -S 0x69 -b 1048576 0 $((64 * 1048576))" $SCRATCH_DEV >> $seqres.full
> -_scratch_mkfs_sized $((64 * 1048576)) > $seqres.full 2>&1
> +$XFS_IO_PROG -d -c "pwrite -S 0x69 -b 1048576 0 $fssize" $SCRATCH_DEV >> $seqres.full
> +_scratch_mkfs_sized $fssize > $seqres.full 2>&1
> _dmerror_init
> _dmerror_mount >> $seqres.full 2>&1
> _dmerror_unmount
> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-02-22 2:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 0:32 [PATCH] generic/25[02]: increase filesystem size Dave Chinner
2018-02-22 2:28 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222022800.GC14582@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox