From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: Eryu Guan <guaneryu@gmail.com>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] common/xfs: don't call xfs_scrub on a block device
Date: Thu, 29 Mar 2018 08:46:01 -0700 [thread overview]
Message-ID: <20180329154601.GB20548@magnolia> (raw)
In-Reply-To: <5ABCBF30.4060403@cn.fujitsu.com>
On Thu, Mar 29, 2018 at 06:25:52PM +0800, Xiao Yang wrote:
> On 2018/03/22 10:46, Darrick J. Wong wrote:
> >From: Darrick J. Wong<darrick.wong@oracle.com>
> >
> >xfs_scrub takes an xfs mountpoint as its argument, not a block device.
> >Therefore, fix _check_xfs_filesystem to call it correctly.
> Hi Darrick,
>
> According to xfs_scrub manpage, it seems that xfs_scrub can take a mounted block device
> as its argument. Is the xfs_scrub manpage incorrect?
Yes, the manpage is wrong and will be fixed in xfsprogs 4.16.
--D
> Thanks,
> Xiao Yang
>
> >Signed-off-by: Darrick J. Wong<darrick.wong@oracle.com>
> >---
> > common/xfs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/common/xfs b/common/xfs
> >index 5dbd81e..1d98ba1 100644
> >--- a/common/xfs
> >+++ b/common/xfs
> >@@ -358,7 +358,7 @@ _check_xfs_filesystem()
> > # Run online scrub if we can.
> > mntpt="$(_is_dev_mounted $device)"
> > if [ -n "$mntpt" ]&& _supports_xfs_scrub "$mntpt" "$device"; then
> >- "$XFS_SCRUB_PROG" $scrubflag -v -d -n $device> $tmp.scrub 2>&1
> >+ "$XFS_SCRUB_PROG" $scrubflag -v -d -n $mntpt> $tmp.scrub 2>&1
> > if [ $? -ne 0 ]; then
> > _log_err "_check_xfs_filesystem: filesystem on $device failed scrub"
> > echo "*** xfs_scrub $scrubflag -v -d -n output ***">> $seqres.full
> >--
> >To unsubscribe from this list: send the line "unsubscribe fstests" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
> >
>
>
>
next prev parent reply other threads:[~2018-03-29 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:57 [PATCH v3] xfs: test agfl reset on bad list wrapping Darrick J. Wong
2018-03-22 2:46 ` [PATCH] common/xfs: don't call xfs_scrub on a block device Darrick J. Wong
2018-03-29 10:25 ` Xiao Yang
2018-03-29 15:46 ` Darrick J. Wong [this message]
2018-03-22 2:48 ` [PATCH] common/xfs: fix various problems with _supports_xfs_scrub Darrick J. Wong
2018-03-23 5:26 ` [PATCH v3] xfs: test agfl reset on bad list wrapping Eryu Guan
2018-03-23 16:08 ` Darrick J. Wong
2018-03-26 1:22 ` Eryu Guan
2018-03-28 1:20 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329154601.GB20548@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox