public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@google.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [xfstests-bld PATCH] test-appliance: fix use of undefined variable in gen_results_summary
Date: Mon,  2 Apr 2018 10:14:13 -0700	[thread overview]
Message-ID: <20180402171413.63324-1-ebiggers@google.com> (raw)

This fixes the following Python error when no tests were run:

    Traceback (most recent call last):
      File "/usr/local/bin/gen_results_summary", line 22, in <module>
	main()
      File "/usr/local/bin/gen_results_summary", line 19, in main
	sys.exit('No results file found in ' + results_dir)
    NameError: global name 'results_dir' is not defined

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 .../test-appliance/files/usr/local/bin/gen_results_summary      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary b/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary
index be4401e..57c4a08 100755
--- a/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary
+++ b/kvm-xfstests/test-appliance/files/usr/local/bin/gen_results_summary
@@ -16,7 +16,7 @@ def main():
 
     if gen_results_summary(args.results_dir, args.output_file,
                            args.merge_file, args.verbose) == 0:
-        sys.exit('No results file found in ' + results_dir)
+        sys.exit('No results file found in ' + args.results_dir)
 
 if __name__ == "__main__":
     main()
-- 
2.17.0.rc1.321.gba9d0f2565-goog


             reply	other threads:[~2018-04-02 17:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 17:14 Eric Biggers [this message]
2018-04-02 18:56 ` [xfstests-bld PATCH] test-appliance: fix use of undefined variable in gen_results_summary Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402171413.63324-1-ebiggers@google.com \
    --to=ebiggers@google.com \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox