Re: [PATCH xfstests] generic/035: Override output for NFS testing

Benjamin Coddington
2018-04-03T12:36:36Z

On 3 Apr 2018, at 8:25, Christoph Hellwig wrote:

> On Tue, Apr 03, 2018 at 08:10:36AM -0400, Benjamin Coddington wrote:
>> No, having nlink == 1 is not a bug and we should expect that behavior, the
>> same with the -ESTALE return for a directory. This is true, at least, for
>> the linux client.
>
> In terms of Linux semantics is plain and simple is a bug. It is an
> expected bug in NFS, but that doesn't make it correct.

Ok yes. I'd still like to test for it, since it's possible we can get this
wrong. Maybe a better approach is to copy this one to an NFS-only test,
with the expected buggy output, and then everything in generic/ can go back
to not having any output overrides.

That keeps us from setting a precedent that any generic/ tests may be
papered over, rather than expected to fail for a particular file system.

Ben