From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@google.com>
Cc: fstests@vger.kernel.org
Subject: Re: [xfstests-bld PATCH] util/parse_cli: use getopt to parse the options
Date: Thu, 5 Apr 2018 22:13:20 -0400 [thread overview]
Message-ID: <20180406021320.GB7345@thunk.org> (raw)
In-Reply-To: <20180405210644.128564-1-ebiggers@google.com>
On Thu, Apr 05, 2018 at 02:06:44PM -0700, Eric Biggers wrote:
> Use getopt to parse the options rather than the custom code that
> iterates through $@. This fixes many anomalies, such as long options
> being accepted in the form '--opt ARG' but not '--opt=ARG'.
getopt is in util-linux, which implies that if there is anyone trying
to launch gce-xfstests from MacOS, it won't work any more with this
commit. I don't *think* this is a problem, and if so a workaround is
to use Cloud Shell[1], but if this change will break anyone, please
speak now....
- Ted
prev parent reply other threads:[~2018-04-06 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 21:06 [xfstests-bld PATCH] util/parse_cli: use getopt to parse the options Eric Biggers
2018-04-06 2:13 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406021320.GB7345@thunk.org \
--to=tytso@mit.edu \
--cc=ebiggers@google.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox