From: Eryu Guan <guaneryu@gmail.com>
To: Filipe Manana <fdmanana@kernel.org>
Cc: fstests <fstests@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH v2] fstests: test btrfs fsync after hole punching with no-holes mode
Date: Mon, 9 Apr 2018 21:05:55 +0800 [thread overview]
Message-ID: <20180409130555.GD2932@desktop> (raw)
In-Reply-To: <CAL3q7H5WDP5U-=OcQkRc-+5fD5mNpgscSyqc=M678Tdn8FBHUg@mail.gmail.com>
On Sun, Apr 08, 2018 at 09:46:24AM +0100, Filipe Manana wrote:
> On Sun, Apr 8, 2018 at 8:46 AM, Eryu Guan <guaneryu@gmail.com> wrote:
> > On Wed, Mar 28, 2018 at 12:55:30PM +0100, fdmanana@kernel.org wrote:
> >> From: Filipe Manana <fdmanana@suse.com>
> >>
> >> Test that when we have the no-holes mode enabled and a specific metadata
> >> layout, if we punch a hole and fsync the file, at replay time the whole
> >> hole was preserved.
> >>
> >> This issue is fixed by the following btrfs patch for the linux kernel:
> >>
> >> "Btrfs: fix fsync after hole punching when using no-holes feature"
> >>
> >> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> >> ---
> >>
> >> V2: Made the test work when selinux is enabled, and made it use direct IO
> >> writes to ensure 256K extents.
> >
> > Test fails with selinux enabled now on unpatched kernel. But I found
> > that, in my release testing, test still fails when testing with current
> > Linus tree (HEAD is 642e7fd23353, without selinux this time), which
> > should contain the mentioned fix. Does that mean the bug is not fully
> > fixed?
>
> The bug is fully fixed. But HEAD 642e7fd23353 does not contain the
> fix. The current linus' master has it.
I'll double check.. Thanks for the heads-up!
Eryu
next prev parent reply other threads:[~2018-04-09 13:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 22:59 [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode fdmanana
2018-03-28 2:17 ` Eryu Guan
2018-03-28 8:48 ` Filipe Manana
2018-03-28 10:33 ` Eryu Guan
2018-03-29 13:45 ` Filipe Manana
2018-03-29 18:55 ` Jayashree Mohan
2018-04-02 14:24 ` Filipe Manana
2018-04-02 16:14 ` Jayashree Mohan
2018-03-30 0:58 ` Eryu Guan
2018-03-28 11:55 ` [PATCH v2] " fdmanana
2018-04-08 7:46 ` Eryu Guan
2018-04-08 8:46 ` Filipe Manana
2018-04-09 13:05 ` Eryu Guan [this message]
2018-04-16 11:28 ` Filipe Manana
2018-04-16 12:35 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409130555.GD2932@desktop \
--to=guaneryu@gmail.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox