From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: [PATCH] xfs/187: fix ftype brokenness
Date: Wed, 11 Apr 2018 09:08:09 -0700 [thread overview]
Message-ID: <20180411160809.GA13697@magnolia> (raw)
From: Darrick J. Wong <darrick.wong@oracle.com>
This test requires XFS_SB_VERSION_MOREBITSBIT to be zero. ftype (which
is now enabled by default) causes this to be set, so detect it in mkfs
and disable it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/187 | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/xfs/187 b/tests/xfs/187
index 07ef3ae..e1a8ce9 100755
--- a/tests/xfs/187
+++ b/tests/xfs/187
@@ -70,8 +70,14 @@ export MOUNT_OPTIONS=""
# lazysb, attr2 and other feature bits are held in features2 and will require
# morebitsbit on So test with lazysb and without it to see if the morebitsbit is
# okay etc. If the mkfs defaults change, these need to change as well.
-export MKFS_NO_LAZY="-m crc=0 -l lazy-count=0 -i projid32bit=0"
-export MKFS_LAZY="-m crc=0 -l lazy-count=1 -i projid32bit=0"
+MKFS_NO_LAZY="-m crc=0 -l lazy-count=0 -i projid32bit=0"
+MKFS_LAZY="-m crc=0 -l lazy-count=1 -i projid32bit=0"
+
+# Detect ftype
+if _scratch_mkfs --help 2>&1 | grep -q "ftype="; then
+ MKFS_NO_LAZY="$MKFS_NO_LAZY -n ftype=0"
+ MKFS_LAZY="$MKFS_LAZY -n ftype=0"
+fi
# Make sure that when we think we are testing with morebits off
# that we really are.
next reply other threads:[~2018-04-11 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 16:08 Darrick J. Wong [this message]
2018-04-13 6:14 ` [PATCH] xfs/187: fix ftype brokenness Eryu Guan
2018-04-13 23:37 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411160809.GA13697@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox