public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] fstests: btrfs/159 superblock corruption test case
Date: Sat, 14 Apr 2018 13:50:35 +0800	[thread overview]
Message-ID: <20180414055035.GI2932@desktop> (raw)
In-Reply-To: <a4195afb-60cd-0183-3ce2-d99338bc0d51@oracle.com>

On Sat, Apr 14, 2018 at 06:43:49AM +0800, Anand Jain wrote:
> 
> > > +# Test if the superblock corruption is handled correctly:
> > > +# 	- Test fsid miss-match (csum ok) between primary and copy superblock
> > > +#	Fixed by the ML patch:
> > > +#	btrfs: check if the fsid in the primary sb and copy sb are same
> > > +# 	- Test if the mount fails if the primary superblock csum is
> > > +#		corrupted on any disk
> > > +# 	- Test if the mount does not fail if the copy1 sb csum is corrupted
> > > +#	Fixed by the ML patches:
> > > +#	btrfs: verify superblock checksum during scan
> > > +#	btrfs: verify checksum for all devices in mount context
> > 
> > Do you have a tree that I can pull from? I want to make sure the test
> > does pass on patched kernel, but the patchset doesn't apply on v4.16
> > kernel.
> 
> We have new discussions on whether to check for the alien-superblock and
> the superblock-checksum at the mount and scan time respectively. And
> depending on its outcome this test-case should be modified as well. So
> can you please defer this fstest patch, for now, I shall send a revised
> fstest patch when kernel patches gets integrated.

Thanks for the heads-up, I'll drop it for now.

> 
> In any case, if you want to give a try, those patches are base on kdave repo
> at [1].
>  [1]
>  https://github.com/kdave/btrfs-devel.git misc-next

Thanks!

Eryu

      reply	other threads:[~2018-04-14  5:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 10:28 [PATCH typo-fixed] fstests: btrfs: 159 superblock corruption test case Anand Jain
2018-04-04  2:46 ` Eryu Guan
2018-04-05  6:14   ` Anand Jain
2018-04-05  6:28 ` [PATCH v2] fstests: btrfs/159 " Anand Jain
2018-04-08  3:38   ` Eryu Guan
2018-04-09  5:24     ` Anand Jain
2018-04-09  5:28 ` [PATCH v3] " Anand Jain
2018-04-13  4:43   ` Eryu Guan
2018-04-13 22:43     ` Anand Jain
2018-04-14  5:50       ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180414055035.GI2932@desktop \
    --to=guaneryu@gmail.com \
    --cc=anand.jain@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox