From: Miklos Szeredi <mszeredi@redhat.com>
To: fstests@vger.kernel.org
Cc: linux-unionfs@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: [PATCH 1/2] overlay/40: clean up properly after setting immutable
Date: Mon, 16 Apr 2018 12:41:40 +0200 [thread overview]
Message-ID: <20180416104141.17134-1-mszeredi@redhat.com> (raw)
Test program expects only immutable on lower layer (test failure), but does
not expect the immutable file to be on the upper layer. The later case is
actually what *should* happen, except overlayfs didn't properly implement
this case yet (but is now in the works).
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
tests/overlay/040 | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/overlay/040 b/tests/overlay/040
index 369fef3c3a47..4fff7570c2c6 100755
--- a/tests/overlay/040
+++ b/tests/overlay/040
@@ -41,7 +41,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
- $CHATTR_PROG -i $lowerdir/foo
+ $CHATTR_PROG -i $lowerdir/foo > /dev/null 2>&1
+ $CHATTR_PROG -i $upperdir/foo > /dev/null 2>&1
rm -f $tmp.*
}
@@ -63,6 +64,7 @@ _scratch_mkfs
# prepare lower test file
lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER
+upperdir=$OVL_BASE_SCRATCH_MNT/$OVL_UPPER
mkdir -p $lowerdir
touch $lowerdir/foo
--
2.14.3
next reply other threads:[~2018-04-16 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 10:41 Miklos Szeredi [this message]
2018-04-16 10:41 ` [PATCH 2/2] overlay/013: do not expect failure Miklos Szeredi
2018-04-16 15:27 ` Amir Goldstein
2018-04-16 15:27 ` [PATCH 1/2] overlay/40: clean up properly after setting immutable Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416104141.17134-1-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox