From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common/rc: move rm out from if block to always delete kmemleak temp file
Date: Sun, 22 Apr 2018 22:40:48 -0700 [thread overview]
Message-ID: <20180423054048.GA26261@magnolia> (raw)
In-Reply-To: <8a5faeaa-e053-ab1b-4712-edec8d32fd93@jp.fujitsu.com>
On Mon, Apr 23, 2018 at 02:23:14PM +0900, Misono Tomohiro wrote:
> Otherwise, *.kmemleak.tmp may remain in result folder if kmemleak is on.
>
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 366489bb..0c3359fd 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3515,8 +3515,8 @@ EXPERIMENTAL kmemleak reported some memory leaks! Due to the way kmemleak
> works, the leak might be from an earlier test, or something totally unrelated.
> ENDL
> cat "$leak_file.tmp" >> "$leak_file"
> - rm -rf "$leak_file.tmp"
> fi
> + rm -rf "$leak_file.tmp"
> echo "clear" > "$kern_knob"
> }
>
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-04-23 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 5:23 [PATCH] common/rc: move rm out from if block to always delete kmemleak temp file Misono Tomohiro
2018-04-23 5:40 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423054048.GA26261@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox