From: David Sterba <dsterba@suse.cz>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: fstests@vger.kernel.org, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs: Add test that checks rmdir(2) can delete a subvolume
Date: Fri, 27 Apr 2018 18:26:35 +0200 [thread overview]
Message-ID: <20180427162635.GF21272@twin.jikos.cz> (raw)
In-Reply-To: <a7ba61de-3bbc-92fd-68db-2521f4bc8545@jp.fujitsu.com>
On Fri, Apr 27, 2018 at 05:02:45PM +0900, Misono Tomohiro wrote:
> Add btrfs test that checks "rmdir" or "rm -r" command can delete a
> subvolume like an ordinary drectory.
>
> This behavior has been restricted long time but becomes allowed by
> following patch in the kernel:
> btrfs: Allow rmdir(2) to delete an empty subvolume
AFAICS this test will fail on older kernels, eg. stable versions, but
this is not a bug that needs to be fixed by backporting patches. The
usual way is to use the expunges, but as this is a feature coverage, I
think the test should detect if the kernel has the feature at all.
Similar to the fallocate modes etc.
For the test itself, the scenarios look sufficient, so
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2018-04-27 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 8:02 [PATCH v2] btrfs: Add test that checks rmdir(2) can delete a subvolume Misono Tomohiro
2018-04-27 8:37 ` Eryu Guan
2018-04-27 16:26 ` David Sterba [this message]
2018-04-28 2:36 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427162635.GF21272@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox