public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.com>
To: fstests@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH] common/btrfs: add helper to detect dump-tree or btrfs-debug-tree
Date: Thu, 17 May 2018 13:18:14 +0200	[thread overview]
Message-ID: <20180517111814.19652-1-dsterba@suse.com> (raw)

The command btrfs-debug-tree is obsolete and was removed in btrfs-progs
version 4.16.1.  The same functionality available as 'btrfs
inspect-internal dump-tree', let's detect which one can be used.  Test
btrfs/085 otherwise fails with btrfs-progs 4.16.1+.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 common/btrfs    | 11 +++++++++++
 common/config   |  1 +
 tests/btrfs/085 |  6 ++----
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/common/btrfs b/common/btrfs
index 79c687f73376..dd02a1c1589d 100644
--- a/common/btrfs
+++ b/common/btrfs
@@ -59,6 +59,17 @@ _require_btrfs_dump_super()
 	fi
 }
 
+_require_btrfs_dump_tree()
+{
+	if [ ! -x "$BTRFS_DUMP_TREE_PROG" ]; then
+		_require_command "$BTRFS_UTIL_PROG" btrfs
+		if ! $BTRFS_UTIL_PROG inspect-internal dump-tree --help >& /dev/null; then
+			_notrun "Missing btrfs-debug-tree or inspect-internal dump-tree"
+		fi
+		BTRFS_DUMP_TREE_PROG="$BTRFS_UTIL_PROG inspect-internal dump-tree"
+	fi
+}
+
 _run_btrfs_util_prog()
 {
 	run_check $BTRFS_UTIL_PROG $*
diff --git a/common/config b/common/config
index cc3180694e26..d121af4ee254 100644
--- a/common/config
+++ b/common/config
@@ -233,6 +233,7 @@ case "$HOSTOS" in
         export DUMP_F2FS_PROG="`set_prog_path dump.f2fs`"
         export BTRFS_UTIL_PROG="`set_prog_path btrfs`"
         export BTRFS_SHOW_SUPER_PROG="`set_prog_path btrfs-show-super`"
+        export BTRFS_DUMP_TREE_PROG="`set_prog_path btrfs-debug-tree`"
 	export BTRFS_CONVERT_PROG="`set_prog_path btrfs-convert`"
         export XFS_FSR_PROG="`set_prog_path xfs_fsr`"
         export MKFS_NFS_PROG="false"
diff --git a/tests/btrfs/085 b/tests/btrfs/085
index 804899724cba..d81bef76b471 100755
--- a/tests/btrfs/085
+++ b/tests/btrfs/085
@@ -55,16 +55,14 @@ _supported_fs btrfs
 _supported_os Linux
 _require_scratch
 _require_dm_target flakey
-
-BTRFS_DEBUG_TREE_PROG="`set_prog_path btrfs-debug-tree`"
-_require_command "$BTRFS_DEBUG_TREE_PROG" btrfs-debug-tree
+_require_btrfs_dump_tree
 
 rm -f $seqres.full
 
 has_orphan_item()
 {
 	INO=$1
-	if $BTRFS_DEBUG_TREE_PROG $SCRATCH_DEV | \
+	if $BTRFS_DUMP_TREE_PROG $SCRATCH_DEV | \
 		grep -q "key (ORPHAN ORPHAN_ITEM $INO)"; then
 		return 0
 	fi
-- 
2.16.2


             reply	other threads:[~2018-05-17 11:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 11:18 David Sterba [this message]
2018-05-21  3:04 ` [PATCH] common/btrfs: add helper to detect dump-tree or btrfs-debug-tree Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517111814.19652-1-dsterba@suse.com \
    --to=dsterba@suse.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox