From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:48059 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbeEUClq (ORCPT ); Sun, 20 May 2018 22:41:46 -0400 Date: Mon, 21 May 2018 12:41:44 +1000 From: Dave Chinner Subject: Re: [PATCH] generic: fix cleanup function for test 490 Message-ID: <20180521024144.GO10363@dastard> References: <20180520184517.8826-1-tytso@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180520184517.8826-1-tytso@mit.edu> Sender: fstests-owner@vger.kernel.org To: Theodore Ts'o Cc: fstests@vger.kernel.org, jack@suse.cz, guaneryu@gmail.com List-ID: On Sun, May 20, 2018 at 02:45:17PM -0400, Theodore Ts'o wrote: > generic/490 fails because cleanup tries to delete . and .. since $tmp > is left unset, and so "rm -f $tmp.*" does nothing useful. Instead > delete temp files created by seek_sanity_test. > > Signed-off-by: Theodore Ts'o > --- > tests/generic/490 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/490 b/tests/generic/490 > index b5042c2e..c0335ca0 100755 > --- a/tests/generic/490 > +++ b/tests/generic/490 > @@ -49,7 +49,7 @@ _require_test_program "seek_sanity_test" > _cleanup() > { > cd / > - rm -f $tmp.* > + rm -f $base_test_file* > } > > $here/src/seek_sanity_test -s 19 -e 20 $base_test_file > $seqres.full 2>&1 || This is wrong. $tmp must always be set in a test, as the infrastructure uses it. Failing to set $tmp will result in stray files being spewed around the place by the test and not cleaned up. Hence the "rm -f $tmp.*" line must stay, the normal tmp=/tmp/$$ line added to the test preamble, and then you can remove the base test file... Cheers, Dave. -- Dave Chinner david@fromorbit.com