public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: [PATCH] xfs/132: unmount scratch fs after test
Date: Mon, 21 May 2018 09:06:48 -0700	[thread overview]
Message-ID: <20180521160648.GI4910@magnolia> (raw)

From: Darrick J. Wong <darrick.wong@oracle.com>

If this test runs successfully, it'll leave a shutdown scratch fs
behind.  The test framework doesn't unmount the fs for us (because we
told it not to check the fs) so the test framework tries to "test -d
$SCRATCH_MNT" and blows up on the IO error it receives from the dead fs.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/132 |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/132 b/tests/xfs/132
index 6bb03e79..3fa695a7 100755
--- a/tests/xfs/132
+++ b/tests/xfs/132
@@ -67,6 +67,7 @@ _scratch_mount
 
 # The corrupt inode should be tripped over during these initial file creates.
 touch $SCRATCH_MNT/file{0,1,2,3,4,5}{0,1,2,3,4,5} 2>&1 | _filter_scratch
+_scratch_unmount
 
 # success, all done
 status=0

             reply	other threads:[~2018-05-21 16:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 16:06 Darrick J. Wong [this message]
2018-05-21 22:51 ` [PATCH] xfs/132: unmount scratch fs after test Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521160648.GI4910@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox