Re: [PATCH] Make ./new work for non-root user

Dave Chinner
2018-05-25T01:30:37Z

On Thu, May 24, 2018 at 08:30:55PM +0200, Jan Kara wrote:
> Currently 'new' script sources common/config which tries to find mkfs
> and fails if not found (which is likely for non-root user). This is
> inconvenient as development usually does not happen as root. In fact the
> vast majority of setup in common/config and common/rc is not necessary
> for 'new'. Split out the necessary bits into new common/config-base and
> use it in 'new'. Cleanup common/rc and common/config now that it's only
> used from 'check'.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
....
> --- a/common/rc
> +++ b/common/rc
> @@ -20,18 +20,9 @@
> # Mountain View, CA 94043, USA, or: http://www.sgi.com
> #-----------------------------------------------------------------------
>
> -BC=$(which bc 2> /dev/null) || BC=
> +. common/config

Doesn't this means we now include common/config in every test setup
routine, even though the environment it sets up is inherited from
the check function.

If so, that's going to add significantly to the individual test
startup time (which already takes a significant fraction of a
second) and this happens hundreds of times over an auto run instead
of only once when we start the test run. It seems wrong to be doing
this over and over again unecessarily....