Re: [PATCH] generic: fix cleanup function for test 490

[Dave Chinner <david@fromorbit.com>]

On Mon, May 21, 2018 at 10:54:00AM +0800, Eryu Guan wrote:
> On Mon, May 21, 2018 at 12:41:44PM +1000, Dave Chinner wrote:
> > On Sun, May 20, 2018 at 02:45:17PM -0400, Theodore Ts'o wrote:
> > > generic/490 fails because cleanup tries to delete . and .. since $tmp
> > > is left unset, and so "rm -f $tmp.*" does nothing useful.  Instead
> > > delete temp files created by seek_sanity_test.
> > > 
> > > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > > ---
> > >  tests/generic/490 | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/generic/490 b/tests/generic/490
> > > index b5042c2e..c0335ca0 100755
> > > --- a/tests/generic/490
> > > +++ b/tests/generic/490
> > > @@ -49,7 +49,7 @@ _require_test_program "seek_sanity_test"
> > >  _cleanup()
> > >  {
> > >  	cd /
> > > -	rm -f $tmp.*
> > > +	rm -f $base_test_file*
> > >  }
> > >  
> > >  $here/src/seek_sanity_test -s 19 -e 20 $base_test_file > $seqres.full 2>&1 ||
> > 
> > This is wrong. $tmp must always be set in a test, as the
> > infrastructure uses it. Failing to set $tmp will result in stray
> > files being spewed around the place by the test and not cleaned up.
> > Hence the "rm -f $tmp.*" line must stay, the normal tmp=/tmp/$$ line
> > added to the test preamble, and then you can remove the base test
> > file...
> 
> Yeah, I wanted to point that out too. So always using the './new' script
> is the recommended way to write new test, it already puts all the common
> setups (including the 'tmp=/tmp/$$' definition and 'rm -f $tmp.*'
> cleanup) in the test template.

Is there a fix committed for this yet? This bug causes the test to
run rm -f .* in the root directory of the machine....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com