From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] fstests: boiler plate reductions
Date: Mon, 4 Jun 2018 13:00:47 +1000 [thread overview]
Message-ID: <20180604030047.GE10972@dastard> (raw)
In-Reply-To: <20180604025035.GC10972@dastard>
On Mon, Jun 04, 2018 at 12:50:36PM +1000, Dave Chinner wrote:
> On Sun, Jun 03, 2018 at 09:51:07PM +0800, Eryu Guan wrote:
> > On Tue, May 29, 2018 at 10:47:50AM +1000, Dave Chinner wrote:
> > > Most (possibly all?) of the code under tests/ has GPL license blurbs
> > > - they'll all get converted by this same process. It's a bit murkier
> > > when it comes to src/ and ltp/, as this code has varied history. For
> > > these directories, the first pass I make will for code that has
> > > explicit GPL licenses. Every other file will need to be looked at
> > > on a case by case basis and done as time permits...
> > >
> > > Please note that I'm not trying to change the license on any of the
> > > code, just change the way it is documented to reduce boilerplate
> > > code. If I've made any changes that modify the license of any
> > > specific code, then I've made a mistake and I need to fix that.
> > > Please point out anywhere you think my actions have not been clear
> > > and obvious.
> > >
> > > Once we have some consensus on how we want to proceed, I'll do the
> > > grunt work and co-ordinate with Eryu on minimising the number of
> > > times I have to rebase a patchset that is going to touch around 1500
> > > files...
> >
> > How would you like to proceed with a minimum number of rebasing times? I
> > think that most rebase work would come from new tests that being added
> > during the whole process, I think I could do
> >
> > 1) simply suspend adding new tests until the whole work is done, or
> > 2) convert new tests myself if there're just a few of them
>
> Easiest thing to do would be for me to convert the tree immediately
> before you send out an update. e.g. do your update, send me a note,
> I'll run the conversion scripts and send you a pull request based on
> the tree you've finished updating....
That said - this works for the licensing changes, because that's
easily scripted. The setup template stuff is going to be a longer
process because it's not so easily scripted. Let's get the license
change sorted first, then I'll worry about the setup template
updates...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-06-04 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 0:47 [RFC PATCH 0/2] fstests: boiler plate reductions Dave Chinner
2018-05-29 0:47 ` [PATCH 1/2] fstests: generic test setup preamble Dave Chinner
2018-06-03 13:53 ` Eryu Guan
2018-06-04 2:58 ` Dave Chinner
2018-05-29 0:47 ` [PATCH 2/2] fstests: start changeover to spdx license tags Dave Chinner
2018-05-29 2:44 ` [RFC PATCH 0/2] fstests: boiler plate reductions Dave Chinner
2018-06-03 13:51 ` Eryu Guan
2018-06-03 17:55 ` Theodore Y. Ts'o
2018-06-04 2:50 ` Dave Chinner
2018-06-04 3:00 ` Dave Chinner [this message]
2018-06-07 5:30 ` Eryu Guan
2018-06-08 6:17 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604030047.GE10972@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).