From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ipmail01.adl6.internode.on.net ([150.101.137.136]:22018 "EHLO ipmail01.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbeFDDAt (ORCPT ); Sun, 3 Jun 2018 23:00:49 -0400 Date: Mon, 4 Jun 2018 13:00:47 +1000 From: Dave Chinner Subject: Re: [RFC PATCH 0/2] fstests: boiler plate reductions Message-ID: <20180604030047.GE10972@dastard> References: <20180529004752.8243-1-david@fromorbit.com> <20180603135107.GK6581@desktop> <20180604025035.GC10972@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180604025035.GC10972@dastard> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: fstests@vger.kernel.org List-ID: On Mon, Jun 04, 2018 at 12:50:36PM +1000, Dave Chinner wrote: > On Sun, Jun 03, 2018 at 09:51:07PM +0800, Eryu Guan wrote: > > On Tue, May 29, 2018 at 10:47:50AM +1000, Dave Chinner wrote: > > > Most (possibly all?) of the code under tests/ has GPL license blurbs > > > - they'll all get converted by this same process. It's a bit murkier > > > when it comes to src/ and ltp/, as this code has varied history. For > > > these directories, the first pass I make will for code that has > > > explicit GPL licenses. Every other file will need to be looked at > > > on a case by case basis and done as time permits... > > > > > > Please note that I'm not trying to change the license on any of the > > > code, just change the way it is documented to reduce boilerplate > > > code. If I've made any changes that modify the license of any > > > specific code, then I've made a mistake and I need to fix that. > > > Please point out anywhere you think my actions have not been clear > > > and obvious. > > > > > > Once we have some consensus on how we want to proceed, I'll do the > > > grunt work and co-ordinate with Eryu on minimising the number of > > > times I have to rebase a patchset that is going to touch around 1500 > > > files... > > > > How would you like to proceed with a minimum number of rebasing times? I > > think that most rebase work would come from new tests that being added > > during the whole process, I think I could do > > > > 1) simply suspend adding new tests until the whole work is done, or > > 2) convert new tests myself if there're just a few of them > > Easiest thing to do would be for me to convert the tree immediately > before you send out an update. e.g. do your update, send me a note, > I'll run the conversion scripts and send you a pull request based on > the tree you've finished updating.... That said - this works for the licensing changes, because that's easily scripted. The setup template stuff is going to be a longer process because it's not so easily scripted. Let's get the license change sorted first, then I'll worry about the setup template updates... Cheers, Dave. -- Dave Chinner david@fromorbit.com