From: Dave Chinner <david@fromorbit.com>
To: Yong Sun <yosun@suse.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536
Date: Mon, 4 Jun 2018 13:09:09 +1000 [thread overview]
Message-ID: <20180604030909.GG10972@dastard> (raw)
In-Reply-To: <20180601083727.13709-1-yosun@suse.com>
On Fri, Jun 01, 2018 at 04:37:27PM +0800, Yong Sun wrote:
> From: yosun <yosun@suse.com>
>
> node size(leaf size) in ppc64le at least 65536, so mkfs with --nodesize smaller than that number will cause a fail on 057 and 122.
>
> Signed-off-by: Yong Sun <yosun@suse.com>
> ---
> tests/btrfs/057 | 6 ++++++
> tests/btrfs/122 | 8 +++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/057 b/tests/btrfs/057
> index a834b763..69d096fb 100755
> --- a/tests/btrfs/057
> +++ b/tests/btrfs/057
> @@ -48,6 +48,12 @@ _require_scratch
>
> rm -f $seqres.full
>
> +# the nodesize in ppc64le is at least 65536, it will mismatch output
> +HARDWARE_PLATFORM=`uname -i`
> +if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
> + _notrun "Not supported on ppc64le with nodesize > 4096"
> +fi
Why doesn't ppc64le support node sizes smaller than 64K? What makes
it different to any other hardware? i.e. we should be checking for
the thing that prevents node sizes <64k, not the hardware platform.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-06-04 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 8:37 [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536 Yong Sun
2018-06-04 3:09 ` Dave Chinner [this message]
[not found] <20180601075702.12467-1-yosun@suse.com>
2018-06-01 8:06 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604030909.GG10972@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=yosun@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox