From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH] common/rc: Fix _require_xfs_io_command for scrub probe
Date: Mon, 4 Jun 2018 08:44:16 -0700 [thread overview]
Message-ID: <20180604154416.GB6086@magnolia> (raw)
In-Reply-To: <1528087812-24372-1-git-send-email-yangx.jy@cn.fujitsu.com>
On Mon, Jun 04, 2018 at 12:50:12PM +0800, Xiao Yang wrote:
> Currently, xfs_io scrub command doesn't allow the probe function
> to have any parameter, so we remove the invalid parameter.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Bleh, sorry I've muddied the waters so much on this. Yes, we changed
the xfs_io 'scrub probe' command not to take any parameters and forgot
to fix this. :/
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 9273ff7..dadbed4 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2148,7 +2148,7 @@ _require_xfs_io_command()
> param_checked=1
> ;;
> "scrub"|"repair")
> - testio=`$XFS_IO_PROG -x -c "$command probe 0" $TEST_DIR 2>&1`
> + testio=`$XFS_IO_PROG -x -c "$command probe" $TEST_DIR 2>&1`
> echo $testio | grep -q "Inappropriate ioctl" && \
> _notrun "xfs_io $command support is missing"
> ;;
> --
> 1.8.3.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-04 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 9:32 [PATCH] xfs: Regression test for vulnerable directory integrity check Xiao Yang
2018-05-25 4:37 ` Darrick J. Wong
2018-05-25 6:33 ` Xiao Yang
2018-05-29 17:53 ` Darrick J. Wong
2018-05-30 4:04 ` Xiao Yang
2018-05-30 4:52 ` Darrick J. Wong
2018-05-30 6:58 ` Eryu Guan
2018-05-30 8:53 ` [PATCH v2] " Xiao Yang
2018-05-30 14:56 ` Darrick J. Wong
2018-06-03 13:37 ` Eryu Guan
2018-06-03 22:56 ` Darrick J. Wong
2018-06-04 4:54 ` Eryu Guan
2018-06-04 4:50 ` [PATCH] common/rc: Fix _require_xfs_io_command for scrub probe Xiao Yang
2018-06-04 15:44 ` Darrick J. Wong [this message]
2018-06-04 5:00 ` [PATCH v2] xfs: Regression test for vulnerable directory integrity check Xiao Yang
2018-06-04 4:55 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604154416.GB6086@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox