Re: [PATCH 5/6] xfs: abstract xfs_info into $XFS_INFO_PROG

Eryu Guan
2018-06-07T11:37:21Z

On Tue, Jun 05, 2018 at 09:43:27AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Abstract calls to xfs_info into $XFS_INFO_PROG like we do for all other
> xfs utilities.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> common/attr | 2 +-
> common/config | 1 +
> common/populate | 18 +++++++++---------
> common/rc | 2 +-

Better to make xfs_info mandatory too when testing xfs, so I did the
below diff on commit

diff --git a/common/rc b/common/rc
index f04c9ea2fd89..9d6665b6c4d7 100644
--- a/common/rc
+++ b/common/rc
@@ -136,6 +136,7 @@ case "$FSTYP" in
[ "$XFS_REPAIR_PROG" = "" ] && _fatal "xfs_repair not found"
[ "$XFS_DB_PROG" = "" ] && _fatal "xfs_db not found"
[ "$MKFS_XFS_PROG" = "" ] && _fatal "mkfs_xfs not found"
+ [ "$XFS_INFO_PROG" = "" ] && _fatal "xfs_info not found"

. ./common/xfs
;;

Thanks,
Eryu