From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [fstests PATCH] generic/223: skip when using DAX
Date: Wed, 13 Jun 2018 16:33:23 -0600 [thread overview]
Message-ID: <20180613223323.GA11638@linux.intel.com> (raw)
In-Reply-To: <20180613222558.GA9432@magnolia>
On Wed, Jun 13, 2018 at 03:25:58PM -0700, Darrick J. Wong wrote:
> On Wed, Jun 13, 2018 at 03:07:42PM -0600, Ross Zwisler wrote:
> > As of these upstream kernel commits:
> >
> > commit 6e2608dfd934 ("xfs, dax: introduce xfs_dax_aops")
> > commit 5f0663bb4a64 ("ext4, dax: introduce ext4_dax_aops")
> >
> > generic/223 fails on XFS and ext4 because filesystems mounted with DAX no
> > longer support bmap. This is desired behavior and will not be fixed,
> > according to:
> >
> > https://lists.01.org/pipermail/linux-nvdimm/2018-April/015383.html
> >
> > So, just skip over generic/223 when using DAX so we don't throw false
> > positive test failures.
>
> Just because we decided not to support FIBMAP on XFSDAX doesn't mean we
> should let this test bitrot. :)
>
> Just out of curiosity, does the following patch fix g/223 for you?
Yep! This makes generic/223 pass in my setup for both DAX and non-DAX, with
both XFS and ext4.
prev parent reply other threads:[~2018-06-13 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 21:07 [fstests PATCH] generic/223: skip when using DAX Ross Zwisler
2018-06-13 22:25 ` Darrick J. Wong
2018-06-13 22:33 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613223323.GA11638@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).