From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]:46050 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933995AbeFVQTK (ORCPT ); Fri, 22 Jun 2018 12:19:10 -0400 Date: Fri, 22 Jun 2018 10:19:08 -0600 From: Ross Zwisler Subject: Re: [fstests PATCH 1/2] src/: fix up mmap() error checking Message-ID: <20180622161908.GB29492@linux.intel.com> References: <20180620225147.12151-1-ross.zwisler@linux.intel.com> <20180622022838.GM2780@desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180622022838.GM2780@desktop> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: Ross Zwisler , fstests@vger.kernel.org, Jan Kara , Dan Williams , Dave Chinner , Christoph Hellwig , linux-nvdimm@lists.01.org, Jeff Moyer , linux-ext4@vger.kernel.org List-ID: On Fri, Jun 22, 2018 at 10:28:38AM +0800, Eryu Guan wrote: > On Wed, Jun 20, 2018 at 04:51:46PM -0600, Ross Zwisler wrote: > > I noticed that in some of my C tests in src/ I was incorrectly checking for > > mmap() failure by looking for NULL instead of MAP_FAILED. Fix those and > > clean up some places where we were testing against -1 (the actual value of > > MAP_FAILED) which was manually being cast to a pointer. > > > > Signed-off-by: Ross Zwisler > > BTW, I've applied this patch, no need to resend it in v2. Okay, thanks for letting me know.