From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 3/3] build: remove <attr/xattr.h> check
Date: Fri, 29 Jun 2018 15:50:26 +0800 [thread overview]
Message-ID: <20180629075026.GA557@fnst.localdomain> (raw)
In-Reply-To: <20180629064602.GV2780@desktop>
On Fri, Jun 29, 2018 at 02:46:02PM +0800, Eryu Guan wrote:
>On Wed, Jun 27, 2018 at 06:18:54PM +0800, Lu Fengqi wrote:
>> Since fsstress and src/t_immutable don't need attr/xattr.h, just remove
>> <attr/xattr.h> check.
>>
>> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
>> ---
>> configure.ac | 1 -
>> m4/package_attrdev.m4 | 11 -----------
>> 2 files changed, 12 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 57092f1c484b..63ea032dc564 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -51,7 +51,6 @@ AC_PACKAGE_NEED_XFSCTL_MACRO
>> AC_PACKAGE_NEED_XFS_HANDLE_H
>>
>> AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
>> -AC_PACKAGE_NEED_ATTR_XATTR_H
>> AC_PACKAGE_NEED_ATTRIBUTES_H
>> AC_PACKAGE_WANT_ATTRLIST_LIBATTR
>> AC_PACKAGE_NEED_GETXATTR_LIBATTR
>> diff --git a/m4/package_attrdev.m4 b/m4/package_attrdev.m4
>> index 12251ceb63c3..6bf21b1799e5 100644
>> --- a/m4/package_attrdev.m4
>> +++ b/m4/package_attrdev.m4
>> @@ -1,14 +1,3 @@
>> -AC_DEFUN([AC_PACKAGE_NEED_ATTR_XATTR_H],
>> - [ AC_CHECK_HEADERS([attr/xattr.h])
>> - if test "$ac_cv_header_attr_xattr_h" != "yes"; then
>> - echo
>> - echo 'FATAL ERROR: attr/xattr.h does not exist.'
>> - echo 'Install the extended attributes (attr) development package.'
>> - echo 'Alternatively, run "make install-dev" from the attr source.'
>> - exit 1
>> - fi
>> - ])
>> -
>
>Looks like we could remove the check for getxattr too.
>
>AC_DEFUN([AC_PACKAGE_NEED_GETXATTR_LIBATTR],
>...
You're right. I will resend the patch.
--
Thanks,
Lu
>
>Thanks,
>Eryu
>
>> AC_DEFUN([AC_PACKAGE_NEED_ATTR_ERROR_H],
>> [ AC_CHECK_HEADERS([attr/error_context.h])
>> if test "$ac_cv_header_attr_error_context_h" != "yes"; then
>> --
>> 2.18.0
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2018-06-29 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 10:18 [PATCH v2 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH v2 1/3] fsstress: remove include <attr/xattr.h> Lu Fengqi
2018-06-27 10:18 ` [PATCH 2/3] src/t_immutable: use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 10:18 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
2018-06-29 6:46 ` Eryu Guan
2018-06-29 7:50 ` Lu Fengqi [this message]
2018-06-30 4:02 ` Eryu Guan
2018-07-02 1:23 ` Lu Fengqi
2018-07-02 3:07 ` Xiao Yang
2018-07-02 5:05 ` Lu Fengqi
-- strict thread matches above, loose matches on Subject: below --
2018-06-27 8:49 [PATCH 0/3] use sys/xattr.h instead of attr/xattr.h Lu Fengqi
2018-06-27 8:49 ` [PATCH 3/3] build: remove <attr/xattr.h> check Lu Fengqi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629075026.GA557@fnst.localdomain \
--to=lufq.fnst@cn.fujitsu.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox