From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Subject: [PATCH] generic/499: stop fsx from probing insert range call
Date: Tue, 10 Jul 2018 15:33:05 +0800 [thread overview]
Message-ID: <20180710073305.23740-1-zlang@redhat.com> (raw)
On some old kernel which supports COLLAPSE_RANGE and ZERO_RANGE,
but doesn't support INSERT_RANGE, this case alway fails as:
QA output created by 499
+main: filesystem does not support fallocate mode FALLOC_FL_INSERT_RANGE, disabling!
Silence is golden
fsx print one more line to break the golden image.
Due to this case don't need to do INSERT_RANGE operations, so use
-I options to prevent fsx from probing INSERT_RANGE call.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
1) I think using -I option of fsx is better than _notrun when find the system
doesn't support INSERT_RANGE.
2) Although PUCH_HOLE isn't needed either, when a system supports COLLAPSE_RANGE
and ZERO_RANGE, it supports PUCH_HOLE too. So I don't use -H option.
Thanks,
Zorro
tests/generic/499 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/499 b/tests/generic/499
index 99d6d308..a2eac6ab 100755
--- a/tests/generic/499
+++ b/tests/generic/499
@@ -50,7 +50,7 @@ ENDL
victim=$SCRATCH_MNT/a
touch $victim
-$here/ltp/fsx --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output
+$here/ltp/fsx -I --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output
echo "Silence is golden"
status=0
--
2.14.4
next reply other threads:[~2018-07-10 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 7:33 Zorro Lang [this message]
2018-07-10 12:24 ` [PATCH] generic/499: stop fsx from probing insert range call Lukas Czerner
2018-07-10 12:38 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710073305.23740-1-zlang@redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox