From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: "Eric Sandeen" <sandeen@sandeen.net>,
"Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>,
fstests@vger.kernel.org
Subject: Re: [RFC PATCH] fstests: add support for hfsplus
Date: Mon, 3 Sep 2018 09:49:06 +1000 [thread overview]
Message-ID: <20180902234906.GC27618@dastard> (raw)
In-Reply-To: <20180902140529.GI3651@desktop>
On Sun, Sep 02, 2018 at 10:05:29PM +0800, Eryu Guan wrote:
> On Sun, Sep 02, 2018 at 12:13:26AM -0500, Eric Sandeen wrote:
> >
> >
> > On 9/1/18 11:03 PM, Ernesto A. Fernández wrote:
> > > On Sun, Sep 02, 2018 at 01:09:57AM +0800, Eryu Guan wrote:
> > >> On Fri, Aug 31, 2018 at 11:05:03PM -0300, Ernesto A. Fernández wrote:
> > >>> It is not possible to set file system size when running mkfs.hfsplus,
> > >>> so use the device mapper as a workaround.
> > >>
> > >> I'd prefer _notrun the test in _scratch_mkfs_sized() instead of this
> > >> workaround, as the harness is expecting to operate $SCRATCH_DEV but this
> > >> workaround may break this assumption in subtle ways, e.g. now
> > >> _check_scratch_fs fails to create hfsplus-tmp device because
> > >> $SCRATCH_DEV may still be mounted.
> > >
> > > I didn't realize $SCRATCH_DEV could still be mounted, sorry. Maybe I can
> > > unmount it before _dmsetup_create(), and remount after _dmsetup_remove()?
> > > Like _check_generic_filesystem() does. Or would that bring other problems?
>
> I haven't seen other problems yet (after just a few simple test runs),
> but I suspect it may break tests in more subtle ways, the
> _check_scratch_fs failure is just an example. And even it works for now,
> and we have to worry about making it continue to work when adding new
> features in the future and that's a maintaining burden we'd better to
> avoid.
Ah, I just replied on the -fsdevel thread saying exactly this....
> > > I know it's ugly, but one test that uses _scratch_mkfs_sized() has helped
> > > me find a number of bugs already. It would be really useful to get it to
> > > work.
> >
> > Has anyone proposed a patch to mkfs.hfsplus to accept a filesystem size?
> > I'd expect that might be less complicated than this sort of devicemapper
> > setup ;)
>
> Yeah, this would be the best way to let _scratch_mkfs_sized() support
> hfsplus :)
.... and this, too. :)
It'll be easy to add a mkfs option check in _scratch_mkfs_sized()
for hfsplus. That should make it work (or not run, as the case
may be) reliably into the future, too.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-09-03 4:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 2:05 [RFC PATCH] fstests: add support for hfsplus Ernesto A. Fernández
2018-09-01 17:09 ` Eryu Guan
2018-09-02 4:03 ` Ernesto A. Fernández
[not found] ` <4445a65e-42b7-5e2e-36fa-45f116f99f33@sandeen.net>
2018-09-02 14:05 ` Eryu Guan
2018-09-02 23:45 ` Ernesto A. Fernández
2018-09-02 23:49 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902234906.GC27618@dastard \
--to=david@fromorbit.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox