public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] tmpfs: don't require TEST_DEV
Date: Sun, 9 Sep 2018 22:56:34 +0800	[thread overview]
Message-ID: <20180909145611.GJ3651@desktop> (raw)
In-Reply-To: <20180903122728.22882-1-mszeredi@redhat.com>

On Mon, Sep 03, 2018 at 02:27:28PM +0200, Miklos Szeredi wrote:
> tmpfs doesn't require a device and the source argument of the mount is ignored.
> If TEST_DEV is not given then set it to "none".
> 
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> ---
>  common/config | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/common/config b/common/config
> index 2f1f27206776..40c2b399a3c7 100644
> --- a/common/config
> +++ b/common/config
> @@ -456,8 +456,9 @@ _check_device()
>  	fi
>  
>  	case "$FSTYP" in
> -	9p)
> +	9p|tmpfs)
>  		# 9p mount tags are just plain strings, so anything is allowed
> +		# tmpfs doesn't use mount source, ignore
>  		;;
>  	overlay)
>  		if [ ! -d "$dev" ]; then
> @@ -657,6 +658,10 @@ get_next_config() {
>  		export RESULT_BASE="$here/results/"
>  	fi
>  
> +	if [ "$FSTYP" == tmpfs -a -z "$TEST_DEV" ]; then
> +		export TEST_DEV=none
> +	fi
> +

Looks like we could ignore SCRATCH_DEV as well, just set it to a
different name. I'll just update it on commit.

Thanks,
Eryu

>  	#  Mandatory Config values.
>  	MC=""
>  	[ -z "$EMAIL" ]          && MC="$MC EMAIL"
> -- 
> 2.14.3
> 

  reply	other threads:[~2018-09-09 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 12:27 [PATCH] tmpfs: don't require TEST_DEV Miklos Szeredi
2018-09-09 14:56 ` Eryu Guan [this message]
2018-09-09 19:07   ` Miklos Szeredi
2018-09-10  4:32     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180909145611.GJ3651@desktop \
    --to=guaneryu@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox