Re: [PATCH] shared/010: avoid dedupe testing blocked on large fs

[Dave Chinner <david@fromorbit.com>]

On Wed, Sep 12, 2018 at 06:15:47PM +0800, Zorro Lang wrote:
> When test on large fs (--large-fs), xfstests preallocates a large
> file in SCRATCH_MNT/ at first. Duperemove will take too long time
> to deal with that large file (many days on 500T XFS). So move
> working directory to a sub-dir underlying $SCRATCH_MNT/.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
> 
> Hi,
> 
> Besides fix this issue, this patch fix another issue passingly. I left
> a bad variable named "testdir" in this case. This patch can fix it.
> 
> If maintainer feels I should fix it in another patch, please tell me:-P
> 
> Thanks,
> Zorro
> 
>  tests/shared/010 | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/shared/010 b/tests/shared/010
> index 1817081b..04f55890 100755
> --- a/tests/shared/010
> +++ b/tests/shared/010
> @@ -65,15 +65,17 @@ function end_test()
>  sleep_time=$((50 * TIME_FACTOR))
>  
>  # Start fsstress
> +testdir="$SCRATCH_MNT/dir"

Can we not call a temporary on the scratch device "testdir"?

Because the "test dir" name specifically refers to the test device
mount point, and using it for anything else (even though it's a
different variable) is just confusing.

Call it something like "local_dir" or "work_dir" or "stress_dir".
But not "testdir".

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com