Re: [PATCH V5 06/20] Fix xfs/139 to work with 64k block size

Chandan Rajendra
2018-10-06T13:51:13Z

On Saturday, October 6, 2018 6:03:38 AM IST Dave Chinner wrote:
> On Mon, Sep 24, 2018 at 08:49:28PM +0530, Chandan Rajendra wrote:
> > For 64k block size, the agsize provided in the test causes mkfs.xfs to
> > fail due to insufficient log space. Hence this commit computes agsize
> > based on block size of the filesystem.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> > ---
> > tests/xfs/139 | 15 +++++++++------
> > tests/xfs/139.out | 8 ++++++--
> > 2 files changed, 15 insertions(+), 8 deletions(-)
> >
> > diff --git a/tests/xfs/139 b/tests/xfs/139
> > index 2a26635..c074273 100755
> > --- a/tests/xfs/139
> > +++ b/tests/xfs/139
> > @@ -34,17 +34,20 @@ _require_cp_reflink
> >
> > rm -f $seqres.full
> >
> > +_scratch_mkfs >/dev/null 2>&1
> > +_scratch_mount
> > +blksz=$(_get_file_block_size $SCRATCH_MNT)
> > +_scratch_unmount
> > +
> > echo "Format and mount"
> > -_scratch_mkfs -d agsize=$((32 * 1048576)) > $seqres.full 2>&1
> > +_scratch_mkfs -d agsize=$((8192 * $blksz)) > $seqres.full 2>&1
>
> This breaks 512 byte and 1k block size filesystems.
>
> $ head -3 139.full
> Invalid value 8388608 for -d agsize option. Value is too small.
> Usage: mkfs.xfs
> /* blocksize */ [-b size=num]
> $
>
> Minimum AG size is 16MB. There are more changes to other tests in
> this series that also demonstrate this regression.

Thanks for mentioning this fact about the minimum AG size. I will verify
all the tests once again.

Also, for xfs/139, 512 byte block size does not apply since reflink feature
requires CRC to be enabled. Nevertheless, I will make sure that mkfs.xfs
actually does succeed for other tests where 512 bytes block size is applicable.

--
chandan