public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Yufen Yu <yuyufen@huawei.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] ext4/018: fix mismatch wildcard with debugfs
Date: Thu, 11 Oct 2018 09:45:41 -0400	[thread overview]
Message-ID: <20181011134541.GA13429@thunk.org> (raw)
In-Reply-To: <20181011131410.3587-1-yuyufen@huawei.com>

On Thu, Oct 11, 2018 at 09:14:10PM +0800, Yufen Yu wrote:
> For the new version of debugfs(v1.44.0+), it changes "File ACL:" format
> from "%sFile ACL: %llu    Directory ACL: %d\n" to "%sFile ACL: %llu\n".
> 
> Thus, update this case accordingly.
> 
> Signed-off-by: Yufen Yu <yuyufen@huawei.com>

Thanks, I don't normally running -g fuzzers so I didn't notice this.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

> ---
>  tests/ext4/018 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ext4/018 b/tests/ext4/018
> index 0116c5f7..eb6d827b 100755
> --- a/tests/ext4/018
> +++ b/tests/ext4/018
> @@ -55,7 +55,7 @@ echo "+ check fs"
>  e2fsck -fn "${SCRATCH_DEV}" >> $seqres.full 2>&1 || _fail "fsck should not fail"
>  
>  echo "+ corrupt image"
> -blk="$(debugfs -R 'stat /attrfile' "${SCRATCH_DEV}" 2> /dev/null | grep 'File ACL:' | sed -e 's/^.*File ACL: \([0-9]*\).*Directory.*$/\1/g')"
> +blk="$(debugfs -R 'stat /attrfile' "${SCRATCH_DEV}" 2> /dev/null | grep 'File ACL:' | sed -e 's/^.*File ACL: \([0-9]*\)/\1/g')"
>  $XFS_IO_PROG -f -c "pwrite -S 0x62 $((blk * blksz + 20)) 8" "${SCRATCH_DEV}" >> $seqres.full
>  
>  echo "+ mount image"
> -- 
> 2.13.6
> 

      reply	other threads:[~2018-10-11 21:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11 13:14 [PATCH] ext4/018: fix mismatch wildcard with debugfs Yufen Yu
2018-10-11 13:45 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011134541.GA13429@thunk.org \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    --cc=yuyufen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox