FS/XFS testing framework
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: guaneryu@gmail.com
Cc: fstests@vger.kernel.org, chao@kernel.org, Chao Yu <yuchao0@huawei.com>
Subject: [PATCH] common/rc: fix to check inode creation on scratch_mnt in _require_btime()
Date: Wed, 24 Oct 2018 10:26:45 +0800	[thread overview]
Message-ID: <20181024022645.74084-1-yuchao0@huawei.com> (raw)

_require_btime() should check inode creation feature on SCRATCH_MNT
mountpoint intead of TEST_DIR mountpoint, otherwise generic/508 will
fail due to incorrect check of this function.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 common/rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/rc b/common/rc
index b4987a9cd7f7..5154241a5cee 100644
--- a/common/rc
+++ b/common/rc
@@ -3845,10 +3845,10 @@ _dmsetup_create()
 
 _require_btime()
 {
-	$XFS_IO_PROG -f $TEST_DIR/test_creation_time -c "statx -v" \
+	$XFS_IO_PROG -f $SCRATCH_MNT/test_creation_time -c "statx -v" \
 		| grep btime >>$seqres.full 2>&1 || \
 		_notrun "inode creation time not supported by this filesystem"
-	rm -f $TEST_DIR/test_creation_time
+	rm -f $SCRATCH_MNT/test_creation_time
 }
 
 init_rc
-- 
2.18.0.rc1

             reply	other threads:[~2018-10-24 11:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24  2:26 Chao Yu [this message]
2018-10-24  4:45 ` [PATCH] common/rc: fix to check inode creation on scratch_mnt in _require_btime() Dave Chinner
2018-10-24  7:25   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181024022645.74084-1-yuchao0@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=chao@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox