From: David Sterba <dsterba@suse.cz>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Omar Sandoval <osandov@osandov.com>,
fstests@vger.kernel.org, kernel-team@fb.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/7] fstests: test Btrfs swapfile support
Date: Tue, 6 Nov 2018 14:06:30 +0100 [thread overview]
Message-ID: <20181106130630.GA24115@twin.jikos.cz> (raw)
In-Reply-To: <20181104160931.GE12788@desktop>
On Mon, Nov 05, 2018 at 12:09:31AM +0800, Eryu Guan wrote:
> On Fri, Nov 02, 2018 at 02:29:35PM -0700, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > This series fixes a couple of generic swapfile tests and adds some
> > Btrfs-specific swapfile tests. Btrfs swapfile support is scheduled for
> > 4.21 [1].
> >
> > 1: https://www.spinics.net/lists/linux-btrfs/msg83454.html
> >
> > Thanks!
>
> Thanks for the fixes and new tests!
>
> >
> > Omar Sandoval (7):
> > generic/{472,496,497}: fix $seeqres typo
> > generic/{472,496}: fix swap file creation on Btrfs
>
> I've merged above two patches, they're two obvious bug fixes.
>
> > btrfs: test swap file activation restrictions
> > btrfs: test invalid operations on a swap file
> > btrfs: test swap files on multiple devices
> > btrfs: test device add/remove/replace with an active swap file
> > btrfs: test balance and resize with an active swap file
>
> These tests look fine to me, but it'd be really great if btrfs folks
> could help review above tests and provide Reviewed-by tags.
All look good to me,
Reviewed-by: David Sterba <dsterba@suse.com>
A few nits I saw:
- the command names should not be shortened, ie. 'btrfs subvolume
snapshot' instead of 'btrfs subvol snap'
- the test description (eg. 3/7 and 4/7) could mention which case is
tested, eg. swapfile with compression or COW or snapshot
- 4/7 has typo 'nowcow' in a comment
next prev parent reply other threads:[~2018-11-06 22:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 21:29 [PATCH 0/7] fstests: test Btrfs swapfile support Omar Sandoval
2018-11-02 21:29 ` [PATCH 1/7] generic/{472,496,497}: fix $seeqres typo Omar Sandoval
2018-11-02 21:29 ` [PATCH 2/7] generic/{472,496}: fix swap file creation on Btrfs Omar Sandoval
2018-11-02 21:29 ` [PATCH 3/7] btrfs: test swap file activation restrictions Omar Sandoval
2018-11-02 21:29 ` [PATCH 4/7] btrfs: test invalid operations on a swap file Omar Sandoval
2018-11-02 21:29 ` [PATCH 5/7] btrfs: test swap files on multiple devices Omar Sandoval
2018-11-02 21:29 ` [PATCH 6/7] btrfs: test device add/remove/replace with an active swap file Omar Sandoval
2018-11-02 21:29 ` [PATCH 7/7] btrfs: test balance and resize " Omar Sandoval
2018-11-06 13:44 ` David Sterba
2018-11-04 16:09 ` [PATCH 0/7] fstests: test Btrfs swapfile support Eryu Guan
2018-11-06 13:06 ` David Sterba [this message]
2018-11-11 14:37 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106130630.GA24115@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox