From: Dave Chinner <david@fromorbit.com>
To: Jayashree Mohan <jayashree2912@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Eryu Guan <guaneryu@gmail.com>,
fstests <fstests@vger.kernel.org>,
Vijaychidambaram Velayudhan Pillai <vijay@cs.utexas.edu>,
Amir Goldstein <amir73il@gmail.com>,
Filipe Manana <fdmanana@gmail.com>
Subject: Re: [PATCH] fstest: CrashMonkey tests ported to xfstest
Date: Thu, 8 Nov 2018 20:40:45 +1100 [thread overview]
Message-ID: <20181108094045.GB6311@dastard> (raw)
In-Reply-To: <20181107020922.GY6311@dastard>
On Wed, Nov 07, 2018 at 01:09:22PM +1100, Dave Chinner wrote:
> To put it in other words, developers need tests focussed on finding
> bugs quickly, not regression tests that provide the core
> requirements of integration and release testing. The development
> testing phase is all about finding fast and effciently.
To emphasis my point of having tests and tools capable of finding
new bugs, I noticed yesterday that fstress and fsx didn't support
copy_file_range, and fsx doesn't support clone/dedupe_file_range
either. Darrick added them overnight.
fsx as run by generic/263 takes *32* operations to find a data
corruption with copy_file_range on XFS. Even changing it to do
buffered IO instead of direct IO, it only takes ~600 operations to
fail with a different data corruption.
That's *at least* two previously unknown bugs exposed in under a
second of runtime.
That's the sort of tooling we need - we don't need hundreds of tests
that are scripted reproducers of fixed problems, we need tools that
exercise boundary conditions and corner cases in ways that are
likely to expose incorrect behaviour. Tools that do these things
quickly and in a reproducable manner are worth their weight in
gold...
IMO, Quality Engineering is not just about writing regression tests
to keep out known bugs - it's most important function is developing
and refining new testing tools to find bugs that have escaped
detection with existing testing methods and tools. If test engineers
can find new bugs, software engineers can fix them. That's really
the ultimate goal here - to find bugs and fix them before users are
exposed to them...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-11-08 19:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 16:50 [PATCH] fstest: CrashMonkey tests ported to xfstest Jayashree Mohan
2018-10-30 13:05 ` Filipe Manana
2018-11-02 20:39 ` Jayashree Mohan
2018-11-04 16:27 ` Eryu Guan
2018-11-04 16:38 ` Eryu Guan
2018-11-04 20:21 ` Jayashree Mohan
2018-11-05 5:22 ` Dave Chinner
2018-11-05 20:16 ` Jayashree Mohan
2018-11-06 22:57 ` Dave Chinner
2018-11-06 23:15 ` Theodore Y. Ts'o
2018-11-06 23:39 ` Dave Chinner
[not found] ` <CA+EzBbDwdi26MCswz0iQ8hUTcGixATUXayxMOmEw5gekYvmMuw@mail.gmail.com>
[not found] ` <5be228d2.1c69fb81.3ad08.5e76.GMR@mx.google.com>
2018-11-06 23:54 ` Delivery Status Notification (Failure) Jayashree Mohan
2018-11-07 2:09 ` [PATCH] fstest: CrashMonkey tests ported to xfstest Dave Chinner
2018-11-07 4:04 ` Theodore Y. Ts'o
2018-11-08 1:41 ` Jayashree Mohan
2018-11-08 9:10 ` Dave Chinner
2018-11-08 14:46 ` Jayashree Mohan
2018-11-08 9:40 ` Dave Chinner [this message]
2018-11-08 15:35 ` Vijaychidambaram Velayudhan Pillai
2018-11-09 3:12 ` Dave Chinner
2018-11-09 16:39 ` Vijaychidambaram Velayudhan Pillai
2018-11-09 19:17 ` Theodore Y. Ts'o
2018-11-09 20:47 ` Vijaychidambaram Velayudhan Pillai
2018-11-08 16:10 ` Theodore Y. Ts'o
2018-11-07 0:24 ` Jayashree Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108094045.GB6311@dastard \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=jayashree2912@gmail.com \
--cc=tytso@mit.edu \
--cc=vijay@cs.utexas.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox