Re: [PATCH 3/3] generic: copy_file_range bounds test

Dave Chinner
2018-12-03T08:17:47Z

On Mon, Dec 03, 2018 at 09:25:19AM +0200, Amir Goldstein wrote:
> On Mon, Dec 3, 2018 at 8:43 AM Dave Chinner <david@fromorbit.com> wrote:
> >
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Test that copy_file_range will return the correct errors for various
> > error conditions and boundary constraints.
....
>
> All the test cases above check for bugs, which I presume your kernel patch
> series is aimed at fixing(?)

Yes. Document the API (I have a man page patch) write the tests to
exercise correct API behaviour (these patches), fix the API
implementation until the tests start passing (still to be posted as
I wait for these to hit mailing list archives so I can point at
them).

> This one last test case tests for new functionality that is not
> currently available
> for any filesystem in upstream kernel.

Yup.

> Does your kernel patch set also add this functionality to xfs? to generic?

Yes and yes. overlay works, too, but I gave up caring about it
because it doesn't support the ioctls xfs_io uses in this test to
change open file state....

> IMO, it would be better to split this test case for new functionality to a new
> test, so that this one can pass on stable kernels once all the bug
> fixes have been
> applied.

Whatever. I'm tired, I've already put in 13 hours on this today and
I'm on the back of four 100+ hour weeks working on nothing but this
broken heap of crap.

Take it or leave it, because I'm just about burnt out on this
right now...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com