Re: [PATCH 0/7] xfstests: add fs-verity tests

Christoph Hellwig
2018-12-12T09:15:55Z

On Tue, Dec 11, 2018 at 09:29:32AM -0800, Eric Biggers wrote:
> Hi Christoph,
>
> On Tue, Dec 11, 2018 at 05:52:31AM -0800, Christoph Hellwig wrote:
> > On Mon, Dec 10, 2018 at 02:21:35PM -0800, Eric Biggers wrote:
> > > Add tests for fs-verity, a new feature for read-only file-based
> > > authenticity protection. fs-verity will be supported by ext4 and f2fs,
> > > and perhaps other filesystems later. Running these tests requires:
> >
> > Seriously, given how broken the current fs-verify support is we should
> > neither merge it into the kernel nor fstests.
> >
> > Nothing against the highlevel feature per-se, but the implementation
> > posted to linux-fsdevel a while ago is simply too broken.
>
> Please explain. Broken, how so? What changes do you suggest, specifically?

Don't magically pass the hash in the file data, that is just broken
beyond repairable.

> Also, if you have feedback it would be helpful if you posted it in response to
> the actual kernel patchset, not just the tests. AFAICS, this is your first time
> responding to any fs-verity related thread, despite it being out for review for
> months; is that correct or did I miss something you previously posted?

No. But given how broken it I'd rather ignore it rather than wasting
my time. It isn't like it did get any other serious review either.