public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guaneryu@gmail.com>
To: Cui Yue <cuiyue-fnst@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/423: statx mask of the reference file is different from the original file
Date: Thu, 10 Jan 2019 16:35:49 +0800	[thread overview]
Message-ID: <20190110083549.GF2803@desktop> (raw)
In-Reply-To: <1547090099-8394-1-git-send-email-cuiyue-fnst@cn.fujitsu.com>

On Wed, Jan 09, 2019 at 10:14:59PM -0500, Cui Yue wrote:
> When running xfstests generic/423 to test system call statx() on hard link files of NFS, it fails.
> error message:
> [!] attr 'stx_mask' differs from ref file, 7ff != e0
> 
> The values of parameter "mask" between the original file and the reference file are different.
> One is STATX_ALL;
> The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME.
> 
> Modify the function get_reference() to pass the "mask" in,
> and change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to "mask".

Thanks for the fix! Patch looks fine to me, but please follow the kernel
rules for submitting patches in the future. The commit log has too long
lines and you're missing Signed-off-by tag. I'll do the update at commit
time, no need to resend.

Thanks,
Eryu

  reply	other threads:[~2019-01-10  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  3:14 [PATCH] generic/423: statx mask of the reference file is different from the original file Cui Yue
2019-01-10  8:35 ` Eryu Guan [this message]
2019-01-11  2:58   ` Eryu Guan
2019-01-11  5:32     ` Cui, Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110083549.GF2803@desktop \
    --to=guaneryu@gmail.com \
    --cc=cuiyue-fnst@cn.fujitsu.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox