From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f193.google.com ([209.85.214.193]:40382 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbfAKC6N (ORCPT ); Thu, 10 Jan 2019 21:58:13 -0500 Received: by mail-pl1-f193.google.com with SMTP id u18so6089446plq.7 for ; Thu, 10 Jan 2019 18:58:12 -0800 (PST) Date: Fri, 11 Jan 2019 10:58:06 +0800 From: Eryu Guan Subject: Re: [PATCH] generic/423: statx mask of the reference file is different from the original file Message-ID: <20190111025806.GC2713@desktop> References: <1547090099-8394-1-git-send-email-cuiyue-fnst@cn.fujitsu.com> <20190110083549.GF2803@desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110083549.GF2803@desktop> Sender: fstests-owner@vger.kernel.org To: Cui Yue Cc: fstests@vger.kernel.org List-ID: On Thu, Jan 10, 2019 at 04:35:49PM +0800, Eryu Guan wrote: > On Wed, Jan 09, 2019 at 10:14:59PM -0500, Cui Yue wrote: > > When running xfstests generic/423 to test system call statx() on hard link files of NFS, it fails. > > error message: > > [!] attr 'stx_mask' differs from ref file, 7ff != e0 > > > > The values of parameter "mask" between the original file and the reference file are different. > > One is STATX_ALL; > > The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME. > > > > Modify the function get_reference() to pass the "mask" in, > > and change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to "mask". > > Thanks for the fix! Patch looks fine to me, but please follow the kernel > rules for submitting patches in the future. The commit log has too long > lines and you're missing Signed-off-by tag. I'll do the update at commit As remindered by Darrick (thanks Darrick!), I need an explicit SOB tag from you. Could You please either resend the patch with proper SOB tag or provide the SOB tag by replying this thread? Thanks, Eryu