From: Dave Chinner <david@fromorbit.com>
To: yangerkun <yangerkun@huawei.com>
Cc: guaneryu@gmail.com, houtao1@huawei.com, fstests@vger.kernel.org
Subject: Re: [PATCH] common/scsi_debug: make sure scsi_debug been removed correctly
Date: Tue, 15 Jan 2019 14:47:43 +1100 [thread overview]
Message-ID: <20190115034743.GS27534@dastard> (raw)
In-Reply-To: <a91e3234-9a4a-27b4-2382-683f773e892c@huawei.com>
On Sat, Jan 12, 2019 at 10:20:26AM +0800, yangerkun wrote:
>
>
> Dave Chinner wrote on 2019/1/10 5:02:
> >On Wed, Jan 09, 2019 at 01:48:45PM +0800, yangerkun wrote:
> >>Case generic/108 sometimes will fail while testing ext2, and the reson
> >>is that rmmod scsi_debug in _put_scsi_debug_dev may randomly fail. Now
> >>add the loop to do rmmod to make sure scsi_debug can be removed
> >>correctly.
> >
> >Why does 'rmmod scsi_debug' randomly fail?
> >
> >What bug does ext2 have that prevents the scsi debug module from
> >being released and hence removed?
>
> It's not a bug with ext2, ever been existing in ext4 too. This patch
> is a reference to 'https://gitlab.com/cryptsetup/cryptsetup.git'
> commit d7b9ed05f0931b416c33c8eb2ff1e6efa39270ff, and the reason why
> need this is that the behavior of udev cannot be speculated, so
> scsi_debug may rmmod failed since udev scan open the device and take
> the reference of module scsi_debug.
IOWs, you copied a hack from cryptsetup tests because you didn't
know about $UDEV_SETTLE_PROG and didn't think to ask if anyone knew
a solution to this problem?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-01-15 3:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 5:48 [PATCH] common/scsi_debug: make sure scsi_debug been removed correctly yangerkun
2019-01-09 21:02 ` Dave Chinner
2019-01-12 2:20 ` yangerkun
2019-01-13 15:21 ` Eryu Guan
2019-01-15 3:47 ` Dave Chinner [this message]
2019-01-15 5:31 ` yangerkun
2019-01-15 6:08 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115034743.GS27534@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=houtao1@huawei.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox