From: Christoph Hellwig <hch@lst.de>
To: fstests@vger.kernel.org
Subject: [PATCH] generic: detect preallocation support for fsx tests 075 and 112
Date: Tue, 5 Feb 2019 19:47:13 +0100 [thread overview]
Message-ID: <20190205184713.20266-1-hch@lst.de> (raw)
Currently generic/075 and generic/112 have two extra fsx passes each that
exercise fsx with preallocation, which are only enabled for XFS.
These tests can also be run with other file systems, given that the XFS
prealloc ioctls are implemented in generic code since the addition of
the fallocate system call. This also means a version of XFS that does
not support preallocation (e.g. because it always writes out of place)
can skip the prealloc tests while still completing the normal fsx tests
just fine.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/generic/075 | 16 +++++++++++-----
tests/generic/112 | 20 +++++++++++++-------
2 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/tests/generic/075 b/tests/generic/075
index 2b957891..8981c560 100755
--- a/tests/generic/075
+++ b/tests/generic/075
@@ -48,11 +48,12 @@ _do_test()
echo "fsx.$_n : $_filter_param"
echo "-----------------------------------------------"
- if [ "$FSTYP" != "xfs" ]
- then
- if [ "$_n" = "1" -o "$_n" = "3" ]
- then
- # HACK: only xfs handles preallocation (-x) so just skip this test
+ if [ "$_n" = "1" -o "$_n" = "3" ]; then
+ if echo $testio | grep -q "Operation not supported"; then
+ #
+ # Skip the prealloc runs if the file system does not support
+ # preallocation
+ #
return
fi
fi
@@ -128,6 +129,11 @@ echo "brevity is wit..."
_check_test_fs
+# check if preallocation is supported
+testfile=$TEST_DIR/$$.xfs_io
+testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1`
+rm -f $testfile 2>&1 > /dev/null
+
# Options:
# -d: debug output for all operations
# -l flen: the upper bound on file size (default 262144)
diff --git a/tests/generic/112 b/tests/generic/112
index 1879e7b5..a6f8fc14 100755
--- a/tests/generic/112
+++ b/tests/generic/112
@@ -48,13 +48,14 @@ _do_test()
echo "fsx.$_n : $_filter_param"
echo "-----------------------------------------------"
- if [ "$FSTYP" != "xfs" ]
- then
- if [ "$_n" = "1" -o "$_n" = "3" ]
- then
- # HACK: only xfs handles preallocation (-x) so just skip this test
- return
- fi
+ if [ "$_n" = "1" -o "$_n" = "3" ]; then
+ if echo $testio | grep -q "Operation not supported"; then
+ #
+ # Skip the prealloc runs if the file system does not support
+ # preallocation
+ #
+ return
+ fi
fi
# This cd and use of -P gets full debug on $here (not TEST_DEV)
@@ -128,6 +129,11 @@ echo "brevity is wit..."
_check_test_fs
+# check if preallocation is supported
+testfile=$TEST_DIR/$$.xfs_io
+testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $testfile 2>&1`
+rm -f $testfile 2>&1 > /dev/null
+
# Options:
# -d: debug output for all operations
# -l flen: the upper bound on file size (default 262144)
--
2.20.1
next reply other threads:[~2019-02-05 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 18:47 Christoph Hellwig [this message]
2019-02-10 11:11 ` [PATCH] generic: detect preallocation support for fsx tests 075 and 112 Eryu Guan
2019-02-11 0:37 ` Dave Chinner
2019-02-14 5:47 ` Eryu Guan
2019-02-14 22:27 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205184713.20266-1-hch@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox