Re: [PATCH] Fix error message when xfs handle library not found

[Dave Chinner <david@fromorbit.com>]

On Tue, Feb 12, 2019 at 05:46:03PM -0600, Eric Sandeen wrote:
> On 2/12/19 3:15 PM, Dave Chinner wrote:
> > [cc linux-xfs@vger.kernel.org]
> > 
> > On Tue, Feb 12, 2019 at 12:59:02PM -0600, Eric Sandeen wrote:
> >> On 2/12/19 12:18 PM, fdmanana@kernel.org wrote:
> >>> From: Filipe Manana <fdmanana@suse.com>
> >>>
> >>> The error message mentions a "make install-lib" target from xfsprogs,
> >>> however that target does not exists in xfsprogs, what exists is a
> >>> target named "install-dev". So fix that and replace "install-lib" with
> >>> "install-dev".
> >>>
> >>> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> >>> ---
> >>>  m4/package_xfslibs.m4 | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4
> >>> index 9be56e11..ad019518 100644
> >>> --- a/m4/package_xfslibs.m4
> >>> +++ b/m4/package_xfslibs.m4
> >>> @@ -83,7 +83,7 @@ AC_DEFUN([AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE],
> >>>          echo
> >>>          echo 'FATAL ERROR: could not find a current XFS handle library.'
> >>>          echo 'Install or upgrade the XFS library package.'
> >>
> >> To fix things up a bit more, I'd probably not refer to the "XFS library package"
> >> because I'm not sure that exists anywhere either, does it?
> >>
> >> In fedora/rhel land, it's in xfsprogs & xfsprogs-devel for development.
> >>
> >> Not sure about suse or debian or ...?
> > 
> > Debian:
> > 
> > $ apt-file search libhandle
> > ....
> > xfslibs-dev: /lib/libhandle.a
> > xfslibs-dev: /lib/libhandle.so
> > xfslibs-dev: /usr/lib/libhandle.a
> > xfslibs-dev: /usr/lib/libhandle.la
> > xfsprogs: /lib/libhandle.so.1
> > xfsprogs: /lib/libhandle.so.1.0.3
> > $
> > 
> > So the libhandle library DSO is shipped in xfsprogs. The /static/
> > library is shipped in xfslibs-dev.
> > 
> > So what is fstests requiring here - the DSO or the static library?
> > If it's the static library, then why does it need that and why can't
> > it use the DSO shipped as part of the main xfsprogs package?
> 
> I don't think it's looking for libhandle.a, I certainly
> don't have that available on my test systems...
> 
> >> Not a huge deal but if nobody ships xfsprogs-libs (or similar) then maybe best
> >> to fix that line as well.
> >>
> >>> -        echo 'Alternatively, run "make install-lib" from the xfsprogs source.'
> >>> +        echo 'Alternatively, run "make install-dev" from the xfsprogs source.'
> >>
> >> and yeah, this part makes sense.
> > 
> > Only if it requires the static libhandle.a library.
> 
> Oh, ok.  And it doesn't.
> 
> so, it should be:
> 
>         echo 'FATAL ERROR: could not find a current XFS handle library.'
>         echo 'Install or upgrade the xfsprogs package.'
>         echo 'Alternatively, run "make install" from the xfsprogs source.'
> 
> ?

Sounds good to me.

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com