public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>,
	xfs <linux-xfs@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>
Subject: [PATCH] xfs/500: fix review comments
Date: Mon, 18 Feb 2019 21:29:05 -0800	[thread overview]
Message-ID: <20190219052905.GH6477@magnolia> (raw)

From: Darrick J. Wong <darrick.wong@oracle.com>

Fix some problems detecting reflink support in the test.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/500   |    5 ++---
 tests/xfs/group |    2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/xfs/500 b/tests/xfs/500
index 7a965c69..370c78ec 100755
--- a/tests/xfs/500
+++ b/tests/xfs/500
@@ -36,10 +36,9 @@ _scratch_mkfs -d extszinherit=8388608 >> $seqres.full 2>&1
 test $? -eq 1 || echo "should have failed extszinherit"
 
 # Try cow extent size hint if supported
-$MKFS_XFS_PROG -N -f $SCRATCH_DEV > $tmp.mkfs
-if grep -q 'reflink=' $tmp.mkfs ; then
+if _scratch_mkfs_xfs_supported -m crc=1,reflink=1 >> $seqres.full 2>&1; then
 	echo cowextsize >> $seqres.full
-	_scratch_mkfs -m reflink=1 -d cowextsize=8388608 >> $seqres.full 2>&1
+	_scratch_mkfs -m reflink=1,crc=1 -d cowextsize=8388608 >> $seqres.full 2>&1
 	test $? -eq 1 || echo "should have failed cowextsize"
 fi
 
diff --git a/tests/xfs/group b/tests/xfs/group
index 76b8a413..0047fb5c 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -497,6 +497,6 @@
 497 dangerous_fuzzers dangerous_scrub dangerous_online_repair
 498 dangerous_fuzzers dangerous_norepair
 499 auto quick
-500 auto quick mkfs
+500 auto quick mkfs prealloc mkfs
 501 auto quick unlink
 502 auto quick unlink

                 reply	other threads:[~2019-02-19  5:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219052905.GH6477@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox