Re: [PATCH] Add new xattr test 532

Eryu Guan
2019-03-08T02:43:00Z

On Wed, Mar 06, 2019 at 09:46:23PM -0500, Ronnie Sahlberg wrote:
>
>
>
>
> ----- Original Message -----
> > From: "Eryu Guan" <guaneryu@gmail.com>
> > To: "Ronnie Sahlberg" <lsahlber@redhat.com>
> > Cc: "fstests" <fstests@vger.kernel.org>
> > Sent: Wednesday, 6 March, 2019 10:52:34 PM
> > Subject: Re: [PATCH] Add new xattr test 532
> >
> > On Tue, Mar 05, 2019 at 02:36:13PM +1000, Ronnie Sahlberg wrote:
> > > This test is cloned from 097 but has had all the tests for trusted.*
> > > removed.
> > > This makes it possible to use this test on filesystems that can only
> > > provide user.* xattrs such as CIFS.
> > >
> > > Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> >
> > Sorry I missed your last patch of this clone..
>
> No worries. I will resend it later once I address Daves concerns.
>
> >
> > Do I need to do special setup for CIFS to support xattr? Currently I got
> > test _notrun because attrs are not supported by CIFS. I was mounting a
> > local samba server with
> >
> > -o vers=3.0 -o username=user,password=passwd,sfu -o
> > context=system_u:object_r:root_t:s0 //localhost/scratch /mnt/scratch
>
> You don't need the 'sfu' mount option but you likely need to make sure you have the proper vfs modules loaded for samba:
> I use this on my share :
>
> [Share]
> path = /Share
> read only = no
> guest ok = no
> vfs objects = acl_xattr, streams_xattr aio_pthread
> ea support = yes
> aio read size = 16384
> aio write size = 16384
>
> I think the only important one is ea support = yes (the xattrs are stored as EAs)

I got xattr working on CIFS now, thanks!

>
>
>
> >
> > Kernel is 5.0.0-rc7.
> >
> > But instead of cloning all the user.* xattr tests, I think it's better
> > to split generic/097, leave all trusted.* xattr tests there and move all
> > user.* xattr tests to this new test. So we don't have to maintain two
> > copys of the same user.* xattr tests.

But it seems you missed above comments when sending new version of the
patch :)

Thanks,
Eryu