From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: Don't delete seqres.full file in generic/077
Date: Tue, 26 Mar 2019 08:46:35 -0700 [thread overview]
Message-ID: <20190326154635.GC6537@magnolia> (raw)
In-Reply-To: <20190326150158.17700-1-nborisov@suse.com>
On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> When this test finishes there is no 079.full file with output from commands.
"077.full" ?
> Sometimes this information is useful for post mortem so stop deleting the
> file upon test completion.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Looks ok to me otherwise,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/generic/077 | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/generic/077 b/tests/generic/077
> index 284e25253c9e..d11b49c6ff15 100755
> --- a/tests/generic/077
> +++ b/tests/generic/077
> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
> _check_scratch_fs
>
> echo "*** all done"
> -rm -f $seqres.full
I had wondered about this myself... :)
--D
> status=0
> exit
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-03-26 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:01 [PATCH] fstests: Don't delete seqres.full file in generic/077 Nikolay Borisov
2019-03-26 15:46 ` Darrick J. Wong [this message]
2019-03-28 15:40 ` Nikolay Borisov
2019-03-30 8:33 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326154635.GC6537@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox