From: "Theodore Ts'o" <tytso@mit.edu>
To: Rishabh Dave <ridave@redhat.com>
Cc: Dave Chinner <david@fromorbit.com>, fstests@vger.kernel.org
Subject: Re: testsuite for ACLs
Date: Fri, 29 Mar 2019 18:56:52 -0400 [thread overview]
Message-ID: <20190329225652.GB15757@mit.edu> (raw)
In-Reply-To: <CA+jMu4QNB+v-r6KmkUfEh-q5r=m=tCxkLkfrLXA+Ajt12g1SQA@mail.gmail.com>
On Fri, Mar 29, 2019 at 09:29:43PM +0530, Rishabh Dave wrote:
>
> Is tests/generic/group a list of titles of testcases? If so, I don't
> understand them.
No. In each of the various tests folders, e.g., test/generic,
tests/ext4, tests/xfs, tests/btrfs, etc. there is a file named group.
This file tells the xfstests infrastructure which tests belong to
which groups. The line:
026 acl quick auto
Says that the test generic/026 is in three groups, "acl", "quick", and
"auto". The "acl" group is for tests that tests acl. The "quick"
group is for a set of tests than run quickly, for people who want to
be able to do a quick validation that the file system is O.K. The
"auto" group is for tests that should be used as part of an automated
regression testing which is much more comprehensive than just running
the "quick" tests.
The generic/077 test also tests acl's. It also tests extended
attributes, and what happens when the disk fills up (enospc):
077 acl attr auto enospc
> I see there are few tests for ACLs in tests/generic/099. I couldn't
> find them before since the tests use chacl and I was looking for
> setfacl and getfacl. I'll compare my testsuite to tests/generic/099,
> create a list of testcases not covered in xfstests-dev and start
> rewriting.
You need to look at a lot more tests than just tests/generic/099. You
need at all of the tests that belong to group "acl". Which you can
find from looking at the files named group in the subdirectory under
the tests directory.
Cheers,
- Ted
next prev parent reply other threads:[~2019-03-29 22:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 13:18 testsuite for ACLs Rishabh Dave
2019-03-25 20:20 ` Darrick J. Wong
2019-03-26 1:43 ` Dave Chinner
2019-03-29 15:59 ` Rishabh Dave
2019-03-29 22:56 ` Theodore Ts'o [this message]
2019-04-10 16:22 ` Rishabh Dave
2019-04-10 16:23 ` Rishabh Dave
2019-04-18 13:26 ` Rishabh Dave
2019-04-19 7:24 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329225652.GB15757@mit.edu \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=ridave@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).