[PATCH] generic/294: skip on NFS

[PATCH] generic/294: skip on NFS

[Murphy Zhou]

Because NFS handles this differently, returning different values.
Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---
 tests/generic/294 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/generic/294 b/tests/generic/294
index b74579ac..f7e763a3 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -27,6 +27,7 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
 
 # Modify as appropriate.
 _supported_fs generic
-- 
2.21.0

Re: [PATCH] generic/294: skip on NFS

[Murphy Zhou]

On Mon, Mar 04, 2019 at 10:50:08AM +0800, Murphy Zhou wrote:
> Because NFS handles this differently, returning different values.
> Details:
> http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Any comments are helpful, :)

Thanks
M

> 
> Signed-off-by: Murphy Zhou <xzhou@redhat.com>
> ---
>  tests/generic/294 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/294 b/tests/generic/294
> index b74579ac..f7e763a3 100755
> --- a/tests/generic/294
> +++ b/tests/generic/294
> @@ -27,6 +27,7 @@ _cleanup()
>  . ./common/filter
>  
>  # real QA test starts here
> +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
>  
>  # Modify as appropriate.
>  _supported_fs generic
> -- 
> 2.21.0
> 

Re: [PATCH] generic/294: skip on NFS

[Eryu Guan]

On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote:
> Because NFS handles this differently, returning different values.
> Details:
> http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
> 
> Signed-off-by: Murphy Zhou <xzhou@redhat.com>

Sorry for the so long delay.. 

> ---
>  tests/generic/294 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/294 b/tests/generic/294
> index b74579ac..f7e763a3 100755
> --- a/tests/generic/294
> +++ b/tests/generic/294
> @@ -27,6 +27,7 @@ _cleanup()
>  . ./common/filter
>  
>  # real QA test starts here
> +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"

I think it's better to filter the output of NFS to follow the golden
output, so when NFS changes behavior, filter fails and we could know
that from test failure.

Thanks,
Eryu

>  
>  # Modify as appropriate.
>  _supported_fs generic
> -- 
> 2.21.0
> 

Re: [PATCH] generic/294: skip on NFS

[Murphy Zhou]

On Mon, Apr 15, 2019 at 12:03:09PM +0800, Eryu Guan wrote:
> On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote:
> > Because NFS handles this differently, returning different values.
> > Details:
> > http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
> > 
> > Signed-off-by: Murphy Zhou <xzhou@redhat.com>
> 
> Sorry for the so long delay.. 

Not at all, :)

Sending v2.

Thanks,
Xiong 

> > ---
> >  tests/generic/294 | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/generic/294 b/tests/generic/294
> > index b74579ac..f7e763a3 100755
> > --- a/tests/generic/294
> > +++ b/tests/generic/294
> > @@ -27,6 +27,7 @@ _cleanup()
> >  . ./common/filter
> >  
> >  # real QA test starts here
> > +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
> 
> I think it's better to filter the output of NFS to follow the golden
> output, so when NFS changes behavior, filter fails and we could know
> that from test failure.
> 
> Thanks,
> Eryu
> 
> >  
> >  # Modify as appropriate.
> >  _supported_fs generic
> > -- 
> > 2.21.0
> > 

[PATCH v2] generic/294: add golden output for nfs

[Murphy Zhou]

Because NFS handles this differently, returning different values.
Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---

v2:
   add a new golden output for nfs instead of _notrun.

 tests/generic/294         | 7 +++++++
 tests/generic/294.out.nfs | 5 +++++
 2 files changed, 12 insertions(+)
 create mode 100644 tests/generic/294.out.nfs

diff --git a/tests/generic/294 b/tests/generic/294
index b74579ac..a355c612 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -7,6 +7,7 @@
 # Tests for EEXIST (not EROFS) for inode creations, if
 # we ask to create an already-existing entity on an RO filesystem
 #
+seqfull=$0
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
@@ -27,6 +28,12 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+# link correct .out file
+if [ $FSTYP == "nfs" ]; then
+	rm -f $seqfull.out
+	ln -sf $seq.out.nfs $seqfull.out
+fi
+
 
 # Modify as appropriate.
 _supported_fs generic
diff --git a/tests/generic/294.out.nfs b/tests/generic/294.out.nfs
new file mode 100644
index 00000000..71ebeecd
--- /dev/null
+++ b/tests/generic/294.out.nfs
@@ -0,0 +1,5 @@
+QA output created by 294
+mknod: 'SCRATCH_MNT/294.test/testnode': Read-only file system
+mkdir: cannot create directory 'SCRATCH_MNT/294.test/testdir': Read-only file system
+touch: cannot touch 'SCRATCH_MNT/294.test/testtarget': Read-only file system
+ln: creating symbolic link 'SCRATCH_MNT/294.test/testlink': File exists
-- 
2.21.0