Re: [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Thu, Apr 25, 2019 at 03:30:27PM +0800, Eryu Guan wrote:
> On Mon, Apr 22, 2019 at 08:48:20AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Remove the typedef usage for the xfs geometry structure.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
> I guess this is due to patch "xfs: bump XFS_IOC_FSGEOMETRY to v5
> structures" which removes the xfs_fsop_geom_t typedef? And I'm wondering
> if xfs/122 needs update too? as xfs/122.out contains an xfs_fsop_geom_t
> entry as well.

xfs/122 does need an update for the new 5.2 ioctls, so yes, I'll send
that one along once they've landed upstream.

In the meantime, the xfs_fsop_geom_t -> struct xfs_fsop_geom conversion
ought to be applied since the struct FOO approach has always worked.

--D

> Thanks,
> Eryu
> 
> > ---
> >  dmapi/src/suite1/cmd/make_rt_sparse.c |    2 +-
> >  ltp/fsstress.c                        |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/dmapi/src/suite1/cmd/make_rt_sparse.c b/dmapi/src/suite1/cmd/make_rt_sparse.c
> > index 14ee8a0d..13fd3676 100644
> > --- a/dmapi/src/suite1/cmd/make_rt_sparse.c
> > +++ b/dmapi/src/suite1/cmd/make_rt_sparse.c
> > @@ -36,7 +36,7 @@ main(
> >  	int	argc,
> >  	char	**argv)
> >  {
> > -	xfs_fsop_geom_t	geom;
> > +	struct  xfs_fsop_geom	geom;
> >  	struct	fsxattr	fsx;
> >  	struct	dioattr	dio;
> >  	char	*pathname;
> > diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> > index 450cf4f1..279da9f1 100644
> > --- a/ltp/fsstress.c
> > +++ b/ltp/fsstress.c
> > @@ -294,7 +294,7 @@ int		errrange;
> >  int		errtag;
> >  opty_t		*freq_table;
> >  int		freq_table_size;
> > -xfs_fsop_geom_t	geom;
> > +struct xfs_fsop_geom	geom;
> >  char		*homedir;
> >  int		*ilist;
> >  int		ilistlen;