public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Murphy Zhou <xzhou@redhat.com>
To: fstests@vger.kernel.org
Cc: darrick.wong@oracle.com, Murphy Zhou <xzhou@redhat.com>
Subject: [PATCH] generic/532: do not break golden silence if attributes_mask is 0
Date: Wed,  8 May 2019 11:11:44 +0800	[thread overview]
Message-ID: <20190508031144.17895-1-xzhou@redhat.com> (raw)

If the filesystem does not support STATX_ATTR, like NFS, setting
both attributes and attributes_mask to 0 seems the right thing to
do. attributes_mask can be 0 only if attributes is also 0.
This situation is covered by the "&" check in the next line.

Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---
 tests/generic/532 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/generic/532 b/tests/generic/532
index ac8b7a89..3f8afa4a 100755
--- a/tests/generic/532
+++ b/tests/generic/532
@@ -44,7 +44,6 @@ check_statx_attributes()
 	echo "MASK:$mask:ATTRS:$attrs:" >> $seqres.full
 
 	test -z "$mask" && _notrun "xfs_io statx command does not support attributes_mask"
-	test $(( mask )) -eq 0 && echo "attributes mask is zero"
 	test $(( attrs & ~(mask) )) -ne 0 && echo "attributes $attrs do not appear in mask $mask"
 }
 
-- 
2.21.0

             reply	other threads:[~2019-05-08  3:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08  3:11 Murphy Zhou [this message]
2019-05-08  3:26 ` [PATCH] generic/532: do not break golden silence if attributes_mask is 0 Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508031144.17895-1-xzhou@redhat.com \
    --to=xzhou@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox