* [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE
@ 2019-05-08 7:10 Jiufei Xue
2019-05-08 9:38 ` Amir Goldstein
2019-05-10 8:31 ` Eryu Guan
0 siblings, 2 replies; 5+ messages in thread
From: Jiufei Xue @ 2019-05-08 7:10 UTC (permalink / raw)
To: fstests; +Cc: darrick.wong, linux-unionfs, amir73il, guaneryu, joseph.qi
It should return error while changing IMMUTABLE_FL and APPEND_FL if the
process has no capability CAP_LINUX_IMMUTABLE.
However, it's not true on overlayfs after kernel version v4.19 since
the process's subjective cred is overridden with ofs->creator_cred
before calling real vfs_ioctl.
The following patch for ovl fix the problem:
"ovl: check the capability before cred overridden"
Add this testcase to cover this bug.
Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
---
v2: add testcases for APPEND_FL and flags clearing. Suggested by
Amir Goldstein.
v3: clear the flags on both the file in cleanup() in case test is
aborted.
common/config | 1 +
tests/generic/545 | 73 +++++++++++++++++++++++++++++++++++++++++++
tests/generic/545.out | 10 ++++++
tests/generic/group | 1 +
4 files changed, 85 insertions(+)
create mode 100755 tests/generic/545
create mode 100755 tests/generic/545.out
diff --git a/common/config b/common/config
index 64f87057..364432bb 100644
--- a/common/config
+++ b/common/config
@@ -196,6 +196,7 @@ export SQLITE3_PROG="$(type -P sqlite3)"
export TIMEOUT_PROG="$(type -P timeout)"
export SETCAP_PROG="$(type -P setcap)"
export GETCAP_PROG="$(type -P getcap)"
+export CAPSH_PROG="$(type -P capsh)"
export CHECKBASHISMS_PROG="$(type -P checkbashisms)"
export XFS_INFO_PROG="$(type -P xfs_info)"
export DUPEREMOVE_PROG="$(type -P duperemove)"
diff --git a/tests/generic/545 b/tests/generic/545
new file mode 100755
index 00000000..da2eac2e
--- /dev/null
+++ b/tests/generic/545
@@ -0,0 +1,73 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2019 Alibaba Group. All Rights Reserved.
+#
+# FS QA Test No. 545
+#
+# Check that we can't set the FS_APPEND_FL and FS_IMMUTABLE_FL inode
+# flags without capbility CAP_LINUX_IMMUTABLE
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ # Cleanup of flags on both file in case test is aborted
+ # (i.e. CTRL-C), so we have no immutable/append-only files
+ $CHATTR_PROG -ia $testdir/file1 2>&1
+ $CHATTR_PROG -ia $testdir/file2 2>&1
+
+ cd /
+ rm -rf $tmp.* $testdir
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/attr
+
+# real QA test starts here
+_supported_os Linux
+_require_chattr i
+_require_chattr a
+_require_command "$CAPSH_PROG" "capsh"
+
+echo "Format and mount"
+testdir="$TEST_DIR/test-$seq"
+rm -rf $testdir
+mkdir $testdir
+
+echo "Create the original files"
+touch $testdir/file1
+touch $testdir/file2
+
+do_filter_output()
+{
+ err_str=`_filter_test_dir | grep "Operation not permitted"`
+ test -n "$err_str" && echo "Operation not permitted"
+}
+
+echo "Try to chattr +ia with capabilities CAP_LINUX_IMMUTABLE"
+$CHATTR_PROG +a $testdir/file1 2>&1
+$CHATTR_PROG +i $testdir/file1 2>&1
+
+echo "Try to chattr +ia/-ia without capability CAP_LINUX_IMMUTABLE"
+$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +a $testdir/file2" 2>&1 | do_filter_output
+$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +i $testdir/file2" 2>&1 | do_filter_output
+
+$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG -i $testdir/file1" 2>&1 | do_filter_output
+$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG -a $testdir/file1" 2>&1 | do_filter_output
+
+echo "Try to chattr -ia with capability CAP_LINUX_IMMUTABLE"
+$CHATTR_PROG -i $testdir/file1 2>&1
+$CHATTR_PROG -a $testdir/file1 2>&1
+
+# success, all done
+status=0
+exit
diff --git a/tests/generic/545.out b/tests/generic/545.out
new file mode 100755
index 00000000..8c6e4082
--- /dev/null
+++ b/tests/generic/545.out
@@ -0,0 +1,10 @@
+QA output created by 545
+Format and mount
+Create the original files
+Try to chattr +ia with capabilities CAP_LINUX_IMMUTABLE
+Try to chattr +ia/-ia without capability CAP_LINUX_IMMUTABLE
+Operation not permitted
+Operation not permitted
+Operation not permitted
+Operation not permitted
+Try to chattr -ia with capability CAP_LINUX_IMMUTABLE
diff --git a/tests/generic/group b/tests/generic/group
index 40deb4d0..7a457e81 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -547,3 +547,4 @@
542 auto quick clone
543 auto quick clone
544 auto quick clone
+545 auto quick cap
--
2.19.1.856.g8858448bb
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE
2019-05-08 7:10 [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE Jiufei Xue
@ 2019-05-08 9:38 ` Amir Goldstein
2019-05-10 8:31 ` Eryu Guan
1 sibling, 0 replies; 5+ messages in thread
From: Amir Goldstein @ 2019-05-08 9:38 UTC (permalink / raw)
To: Jiufei Xue; +Cc: fstests, Darrick J. Wong, overlayfs, Eryu Guan, joseph.qi
On Wed, May 8, 2019 at 10:10 AM Jiufei Xue <jiufei.xue@linux.alibaba.com> wrote:
>
> It should return error while changing IMMUTABLE_FL and APPEND_FL if the
> process has no capability CAP_LINUX_IMMUTABLE.
>
> However, it's not true on overlayfs after kernel version v4.19 since
> the process's subjective cred is overridden with ofs->creator_cred
> before calling real vfs_ioctl.
>
> The following patch for ovl fix the problem:
> "ovl: check the capability before cred overridden"
>
> Add this testcase to cover this bug.
>
> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
> v2: add testcases for APPEND_FL and flags clearing. Suggested by
> Amir Goldstein.
> v3: clear the flags on both the file in cleanup() in case test is
> aborted.
>
> common/config | 1 +
> tests/generic/545 | 73 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/545.out | 10 ++++++
> tests/generic/group | 1 +
> 4 files changed, 85 insertions(+)
> create mode 100755 tests/generic/545
> create mode 100755 tests/generic/545.out
>
> diff --git a/common/config b/common/config
> index 64f87057..364432bb 100644
> --- a/common/config
> +++ b/common/config
> @@ -196,6 +196,7 @@ export SQLITE3_PROG="$(type -P sqlite3)"
> export TIMEOUT_PROG="$(type -P timeout)"
> export SETCAP_PROG="$(type -P setcap)"
> export GETCAP_PROG="$(type -P getcap)"
> +export CAPSH_PROG="$(type -P capsh)"
> export CHECKBASHISMS_PROG="$(type -P checkbashisms)"
> export XFS_INFO_PROG="$(type -P xfs_info)"
> export DUPEREMOVE_PROG="$(type -P duperemove)"
> diff --git a/tests/generic/545 b/tests/generic/545
> new file mode 100755
> index 00000000..da2eac2e
> --- /dev/null
> +++ b/tests/generic/545
> @@ -0,0 +1,73 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2019 Alibaba Group. All Rights Reserved.
> +#
> +# FS QA Test No. 545
> +#
> +# Check that we can't set the FS_APPEND_FL and FS_IMMUTABLE_FL inode
> +# flags without capbility CAP_LINUX_IMMUTABLE
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + # Cleanup of flags on both file in case test is aborted
> + # (i.e. CTRL-C), so we have no immutable/append-only files
> + $CHATTR_PROG -ia $testdir/file1 2>&1
> + $CHATTR_PROG -ia $testdir/file2 2>&1
> +
> + cd /
> + rm -rf $tmp.* $testdir
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +. ./common/attr
> +
> +# real QA test starts here
> +_supported_os Linux
> +_require_chattr i
> +_require_chattr a
> +_require_command "$CAPSH_PROG" "capsh"
> +
> +echo "Format and mount"
> +testdir="$TEST_DIR/test-$seq"
> +rm -rf $testdir
> +mkdir $testdir
> +
> +echo "Create the original files"
> +touch $testdir/file1
> +touch $testdir/file2
> +
> +do_filter_output()
> +{
> + err_str=`_filter_test_dir | grep "Operation not permitted"`
> + test -n "$err_str" && echo "Operation not permitted"
> +}
> +
> +echo "Try to chattr +ia with capabilities CAP_LINUX_IMMUTABLE"
> +$CHATTR_PROG +a $testdir/file1 2>&1
> +$CHATTR_PROG +i $testdir/file1 2>&1
> +
> +echo "Try to chattr +ia/-ia without capability CAP_LINUX_IMMUTABLE"
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +a $testdir/file2" 2>&1 | do_filter_output
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +i $testdir/file2" 2>&1 | do_filter_output
> +
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG -i $testdir/file1" 2>&1 | do_filter_output
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG -a $testdir/file1" 2>&1 | do_filter_output
> +
> +echo "Try to chattr -ia with capability CAP_LINUX_IMMUTABLE"
> +$CHATTR_PROG -i $testdir/file1 2>&1
> +$CHATTR_PROG -a $testdir/file1 2>&1
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/generic/545.out b/tests/generic/545.out
> new file mode 100755
> index 00000000..8c6e4082
> --- /dev/null
> +++ b/tests/generic/545.out
> @@ -0,0 +1,10 @@
> +QA output created by 545
> +Format and mount
> +Create the original files
> +Try to chattr +ia with capabilities CAP_LINUX_IMMUTABLE
> +Try to chattr +ia/-ia without capability CAP_LINUX_IMMUTABLE
> +Operation not permitted
> +Operation not permitted
> +Operation not permitted
> +Operation not permitted
> +Try to chattr -ia with capability CAP_LINUX_IMMUTABLE
> diff --git a/tests/generic/group b/tests/generic/group
> index 40deb4d0..7a457e81 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -547,3 +547,4 @@
> 542 auto quick clone
> 543 auto quick clone
> 544 auto quick clone
> +545 auto quick cap
> --
> 2.19.1.856.g8858448bb
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE
2019-05-08 7:10 [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE Jiufei Xue
2019-05-08 9:38 ` Amir Goldstein
@ 2019-05-10 8:31 ` Eryu Guan
1 sibling, 0 replies; 5+ messages in thread
From: Eryu Guan @ 2019-05-10 8:31 UTC (permalink / raw)
To: Jiufei Xue; +Cc: fstests, darrick.wong, linux-unionfs, amir73il, joseph.qi
On Wed, May 08, 2019 at 03:10:00PM +0800, Jiufei Xue wrote:
> It should return error while changing IMMUTABLE_FL and APPEND_FL if the
> process has no capability CAP_LINUX_IMMUTABLE.
>
> However, it's not true on overlayfs after kernel version v4.19 since
> the process's subjective cred is overridden with ofs->creator_cred
> before calling real vfs_ioctl.
>
> The following patch for ovl fix the problem:
> "ovl: check the capability before cred overridden"
>
> Add this testcase to cover this bug.
>
> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Thanks for the patch! Some minor issues inline, and I can fix them up on
commit.
> ---
> v2: add testcases for APPEND_FL and flags clearing. Suggested by
> Amir Goldstein.
> v3: clear the flags on both the file in cleanup() in case test is
> aborted.
>
> common/config | 1 +
> tests/generic/545 | 73 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/545.out | 10 ++++++
> tests/generic/group | 1 +
> 4 files changed, 85 insertions(+)
> create mode 100755 tests/generic/545
> create mode 100755 tests/generic/545.out
mode of .out file should be 100644
>
> diff --git a/common/config b/common/config
> index 64f87057..364432bb 100644
> --- a/common/config
> +++ b/common/config
> @@ -196,6 +196,7 @@ export SQLITE3_PROG="$(type -P sqlite3)"
> export TIMEOUT_PROG="$(type -P timeout)"
> export SETCAP_PROG="$(type -P setcap)"
> export GETCAP_PROG="$(type -P getcap)"
> +export CAPSH_PROG="$(type -P capsh)"
> export CHECKBASHISMS_PROG="$(type -P checkbashisms)"
> export XFS_INFO_PROG="$(type -P xfs_info)"
> export DUPEREMOVE_PROG="$(type -P duperemove)"
> diff --git a/tests/generic/545 b/tests/generic/545
> new file mode 100755
> index 00000000..da2eac2e
> --- /dev/null
> +++ b/tests/generic/545
> @@ -0,0 +1,73 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2019 Alibaba Group. All Rights Reserved.
> +#
> +# FS QA Test No. 545
> +#
> +# Check that we can't set the FS_APPEND_FL and FS_IMMUTABLE_FL inode
> +# flags without capbility CAP_LINUX_IMMUTABLE
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + # Cleanup of flags on both file in case test is aborted
> + # (i.e. CTRL-C), so we have no immutable/append-only files
> + $CHATTR_PROG -ia $testdir/file1 2>&1
> + $CHATTR_PROG -ia $testdir/file2 2>&1
$CHATTR_PROG -ia $testdir/file2 >/dev/null 2>&1
And use 8 spaces tab for indention.
> +
> + cd /
> + rm -rf $tmp.* $testdir
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +. ./common/attr
> +
> +# real QA test starts here
> +_supported_os Linux
_supported_fs generic
> +_require_chattr i
> +_require_chattr a
> +_require_command "$CAPSH_PROG" "capsh"
Need _require_test too.
> +
> +echo "Format and mount"
Not needed, you don't do format and mount anyway :)
> +testdir="$TEST_DIR/test-$seq"
I renamed it to workdir to avoid the confusion with TEST_DIR.
> +rm -rf $testdir
> +mkdir $testdir
> +
> +echo "Create the original files"
> +touch $testdir/file1
> +touch $testdir/file2
> +
> +do_filter_output()
> +{
> + err_str=`_filter_test_dir | grep "Operation not permitted"`
> + test -n "$err_str" && echo "Operation not permitted"
I think this is sufficient
grep -o "Operation not permitted"
> +}
> +
> +echo "Try to chattr +ia with capabilities CAP_LINUX_IMMUTABLE"
> +$CHATTR_PROG +a $testdir/file1 2>&1
> +$CHATTR_PROG +i $testdir/file1 2>&1
No need to do the redirection, 'check' will capture both stdout and
stderr.
> +
> +echo "Try to chattr +ia/-ia without capability CAP_LINUX_IMMUTABLE"
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +a $testdir/file2" 2>&1 | do_filter_output
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +i $testdir/file2" 2>&1 | do_filter_output
> +
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG -i $testdir/file1" 2>&1 | do_filter_output
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG -a $testdir/file1" 2>&1 | do_filter_output
> +
> +echo "Try to chattr -ia with capability CAP_LINUX_IMMUTABLE"
> +$CHATTR_PROG -i $testdir/file1 2>&1
> +$CHATTR_PROG -a $testdir/file1 2>&1
Same here, no redirection.
Thanks,
Eryu
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/generic/545.out b/tests/generic/545.out
> new file mode 100755
> index 00000000..8c6e4082
> --- /dev/null
> +++ b/tests/generic/545.out
> @@ -0,0 +1,10 @@
> +QA output created by 545
> +Format and mount
> +Create the original files
> +Try to chattr +ia with capabilities CAP_LINUX_IMMUTABLE
> +Try to chattr +ia/-ia without capability CAP_LINUX_IMMUTABLE
> +Operation not permitted
> +Operation not permitted
> +Operation not permitted
> +Operation not permitted
> +Try to chattr -ia with capability CAP_LINUX_IMMUTABLE
> diff --git a/tests/generic/group b/tests/generic/group
> index 40deb4d0..7a457e81 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -547,3 +547,4 @@
> 542 auto quick clone
> 543 auto quick clone
> 544 auto quick clone
> +545 auto quick cap
> --
> 2.19.1.856.g8858448bb
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE
@ 2019-05-07 11:29 Jiufei Xue
2019-05-07 15:23 ` Amir Goldstein
0 siblings, 1 reply; 5+ messages in thread
From: Jiufei Xue @ 2019-05-07 11:29 UTC (permalink / raw)
To: fstests; +Cc: guaneryu, linux-unionfs, amir73il, joseph.qi
It should return error while changing IMMUTABLE_FL flag if the process
has no capability CAP_LINUX_IMMUTABLE.
However, it's not true on overlayfs after kernel version v4.19 since
the process's subjective cred is overridden with ofs->creator_cred
before calling real vfs_ioctl.
The following patch for ovl fix the problem:
"ovl: check the capability before cred overridden"
Add this testcase to cover this bug.
Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
---
common/config | 1 +
tests/generic/545 | 61 +++++++++++++++++++++++++++++++++++++++++++
tests/generic/545.out | 5 ++++
tests/generic/group | 1 +
4 files changed, 68 insertions(+)
create mode 100755 tests/generic/545
create mode 100755 tests/generic/545.out
diff --git a/common/config b/common/config
index 64f87057..364432bb 100644
--- a/common/config
+++ b/common/config
@@ -196,6 +196,7 @@ export SQLITE3_PROG="$(type -P sqlite3)"
export TIMEOUT_PROG="$(type -P timeout)"
export SETCAP_PROG="$(type -P setcap)"
export GETCAP_PROG="$(type -P getcap)"
+export CAPSH_PROG="$(type -P capsh)"
export CHECKBASHISMS_PROG="$(type -P checkbashisms)"
export XFS_INFO_PROG="$(type -P xfs_info)"
export DUPEREMOVE_PROG="$(type -P duperemove)"
diff --git a/tests/generic/545 b/tests/generic/545
new file mode 100755
index 00000000..89bdf885
--- /dev/null
+++ b/tests/generic/545
@@ -0,0 +1,61 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2015, Oracle and/or its affiliates. All Rights Reserved.
+#
+# FS QA Test No. 545
+#
+# Check that we can't add IMMUTABLE_FL flag to file when the process has
+# no capbility CAP_LINUX_IMMUTABLE
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ $CHATTR_PROG -i $testdir/file 2>&1
+ cd /
+ rm -rf $tmp.* $testdir
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+. ./common/attr
+
+# real QA test starts here
+_supported_os Linux
+_require_chattr i
+_require_command "$CAPSH_PROG" "capsh"
+
+rm -f $seqres.full
+
+echo "Format and mount"
+testdir="$TEST_DIR/test-$seq"
+rm -rf $testdir
+mkdir $testdir
+
+echo "Create the original files"
+blksz="$(_get_block_size $testdir)"
+blks=1000
+sz=$((blksz * blks))
+_pwrite_byte 0x61 0 $sz $testdir/file >> $seqres.full
+sync
+
+do_filter_output()
+{
+ err_str=`_filter_test_dir | grep "Operation not permitted"`
+ test -n "$err_str" && echo "Operation not permitted"
+}
+
+echo "Try to add IMMUTABLE_FL flag"
+$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +i $testdir/file" 2>&1 | do_filter_output
+
+# success, all done
+status=0
+exit
diff --git a/tests/generic/545.out b/tests/generic/545.out
new file mode 100755
index 00000000..740bb980
--- /dev/null
+++ b/tests/generic/545.out
@@ -0,0 +1,5 @@
+QA output created by 545
+Format and mount
+Create the original files
+Try to add IMMUTABLE_FL flag
+Operation not permitted
diff --git a/tests/generic/group b/tests/generic/group
index 40deb4d0..2f60b4af 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -547,3 +547,4 @@
542 auto quick clone
543 auto quick clone
544 auto quick clone
+545 auto quick clone
--
2.19.1.856.g8858448bb
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE
2019-05-07 11:29 Jiufei Xue
@ 2019-05-07 15:23 ` Amir Goldstein
0 siblings, 0 replies; 5+ messages in thread
From: Amir Goldstein @ 2019-05-07 15:23 UTC (permalink / raw)
To: Jiufei Xue; +Cc: fstests, Eryu Guan, overlayfs, joseph.qi, Darrick J. Wong
On Tue, May 7, 2019 at 2:29 PM Jiufei Xue <jiufei.xue@linux.alibaba.com> wrote:
>
> It should return error while changing IMMUTABLE_FL flag if the process
> has no capability CAP_LINUX_IMMUTABLE.
>
> However, it's not true on overlayfs after kernel version v4.19 since
> the process's subjective cred is overridden with ofs->creator_cred
> before calling real vfs_ioctl.
>
> The following patch for ovl fix the problem:
> "ovl: check the capability before cred overridden"
>
> Add this testcase to cover this bug.
>
> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
> ---
> common/config | 1 +
> tests/generic/545 | 61 +++++++++++++++++++++++++++++++++++++++++++
> tests/generic/545.out | 5 ++++
> tests/generic/group | 1 +
> 4 files changed, 68 insertions(+)
> create mode 100755 tests/generic/545
> create mode 100755 tests/generic/545.out
>
> diff --git a/common/config b/common/config
> index 64f87057..364432bb 100644
> --- a/common/config
> +++ b/common/config
> @@ -196,6 +196,7 @@ export SQLITE3_PROG="$(type -P sqlite3)"
> export TIMEOUT_PROG="$(type -P timeout)"
> export SETCAP_PROG="$(type -P setcap)"
> export GETCAP_PROG="$(type -P getcap)"
> +export CAPSH_PROG="$(type -P capsh)"
> export CHECKBASHISMS_PROG="$(type -P checkbashisms)"
> export XFS_INFO_PROG="$(type -P xfs_info)"
> export DUPEREMOVE_PROG="$(type -P duperemove)"
> diff --git a/tests/generic/545 b/tests/generic/545
> new file mode 100755
> index 00000000..89bdf885
> --- /dev/null
> +++ b/tests/generic/545
> @@ -0,0 +1,61 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2015, Oracle and/or its affiliates. All Rights Reserved.
Wrongly copied.
> +#
> +# FS QA Test No. 545
> +#
> +# Check that we can't add IMMUTABLE_FL flag to file when the process has
> +# no capbility CAP_LINUX_IMMUTABLE
Better check APPEND_FL while at it. Trivial to add.
Another think worth testing is chattr -i, so for example you could
touch foo bar
chattr +ia foo
capsh...
chattr +a bar # fail
chattr +i bar # fail
chattr -i foo # fail
chattr -a foo # fail
Order matters, because after Darrick's patches
chattr -/+a on immutable file should fail regardless of capabilities.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +_cleanup()
> +{
> + $CHATTR_PROG -i $testdir/file 2>&1
> + cd /
> + rm -rf $tmp.* $testdir
> +}
> +
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +. ./common/attr
> +
> +# real QA test starts here
> +_supported_os Linux
> +_require_chattr i
> +_require_command "$CAPSH_PROG" "capsh"
> +
> +rm -f $seqres.full
> +
> +echo "Format and mount"
> +testdir="$TEST_DIR/test-$seq"
> +rm -rf $testdir
> +mkdir $testdir
> +
> +echo "Create the original files"
> +blksz="$(_get_block_size $testdir)"
> +blks=1000
> +sz=$((blksz * blks))
> +_pwrite_byte 0x61 0 $sz $testdir/file >> $seqres.full
> +sync
touch $testdir/file is plenty enough
> +
> +do_filter_output()
> +{
> + err_str=`_filter_test_dir | grep "Operation not permitted"`
> + test -n "$err_str" && echo "Operation not permitted"
> +}
> +
> +echo "Try to add IMMUTABLE_FL flag"
> +$CAPSH_PROG --drop=cap_linux_immutable -- -c "$CHATTR_PROG +i $testdir/file" 2>&1 | do_filter_output
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/generic/545.out b/tests/generic/545.out
> new file mode 100755
> index 00000000..740bb980
> --- /dev/null
> +++ b/tests/generic/545.out
> @@ -0,0 +1,5 @@
> +QA output created by 545
> +Format and mount
> +Create the original files
> +Try to add IMMUTABLE_FL flag
> +Operation not permitted
> diff --git a/tests/generic/group b/tests/generic/group
> index 40deb4d0..2f60b4af 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -547,3 +547,4 @@
> 542 auto quick clone
> 543 auto quick clone
> 544 auto quick clone
> +545 auto quick clone
Not 'clone'. Perhaps 'cap', although from the 5 tests that use setcap,
only one uses this tag.
You may send another patch to amend that if you want.
Thanks,
Amir.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-10 8:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-08 7:10 [PATCH] generic: add a testcase to check the capability CAP_LINUX_IMMUTABLE Jiufei Xue
2019-05-08 9:38 ` Amir Goldstein
2019-05-10 8:31 ` Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2019-05-07 11:29 Jiufei Xue
2019-05-07 15:23 ` Amir Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).